From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E8372652A2 for ; Mon, 17 Nov 2025 12:30:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763382623; cv=none; b=f6DyfM2s41obTV90i9FaU7xPhFIeR0sxws64QzpDkFaZLBB0/+dst+fAbE44UwRlFUoKjAqiEn5yr06uNpDtUlKiNHHbf+kYqwgfOGF+M4IaiIHt7YsMEWsEnGljdJN4oHDk/KkWUrUiqb7ZxVU9YiA/tWFGwzibeg9l/wI39yM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763382623; c=relaxed/simple; bh=r7R1b9wUBDzUXuulPCqVqpGc7iIfAPgHde6sJdwLc0Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BQs70Ozdr0X3/XQRz4ouF5Lm7DqckWxQa6yCqKbGvu5NoGAXOfDcTKqKwOBOFVMKYVXzpFO+QT3TmYFO/smVK9HocuDJf+2oMa16xVBSgfj2Yiv3os/4nWsWgN9aup0ZCYkVbsTpSqLBHEI1yrRVVV+XLXephtB99+2+aVI/4D0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TsAYVHL+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Oi5V44Ch; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TsAYVHL+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Oi5V44Ch" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AHB2T0A3916554 for ; Mon, 17 Nov 2025 12:30:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Jg+vEurhb/UOj9r6Pwi2HGIyI+qf8acnrXpyNCLCH3Q=; b=TsAYVHL+aMIoiDe8 d+31Ju7EnOEtvbOVDJG4sjSyU7ugBCYEIpUoO0zqcjvEKn112CJI2nFujGkrMInn RhYHnuKzWJzTjHqqH/VeufrXZQlo8T2lCV9R0i9Evq6I2eFhQb07ndkeiYNoskK/ CEP7i2VS6TDF9M4c52soebvezrcgaQ62hzp4iWVoba5eJwZzf17rewBBVEmRygrf jA3umkuRjA0n9Y5E/ZfeyZ2TIHoXiVwIBmT9ecHD4hsBtacIzwLNCRJnzTGCkcZJ 3G8mocmf2bDXdMBsGVcYPth0TdwN7ESw+GMEnk2j07O0getjA/CPB614u9x93fxc GqBs9Q== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ag2fx8884-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Nov 2025 12:30:20 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-87ff7511178so18277636d6.2 for ; Mon, 17 Nov 2025 04:30:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763382619; x=1763987419; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Jg+vEurhb/UOj9r6Pwi2HGIyI+qf8acnrXpyNCLCH3Q=; b=Oi5V44Ch7Pr+gKs3F7QLvyD+qx1ms0qby8uyCiCru99SQ0Uj2aY+5G6ab0OcIDs5JR 694RgjYog4SlS7g86G9uJKME1ywOcPJSd/6t5z4PXRF+KT7rGYFbsMn5/mRN/l5MrS68 YYk4+7zQCzG7HAWhzjPlwgWhtvLKi73JD2qsqIkSuk+unqztMgbXp2Uo2DUOvNN9Uzr3 DTlgpgmoMhtdbPHnegIGXcwO+ozvC72ZHSE5YBk6jq1CT6SVlw3lYqhOh5EC38c4iuow GOKREqgbto0qGzLEAStpPQibeUOc8hyy2xjRpQd+9wcQyUB4vpb9hCo6Gt6RuJp8/PXb Pfbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763382619; x=1763987419; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Jg+vEurhb/UOj9r6Pwi2HGIyI+qf8acnrXpyNCLCH3Q=; b=EghVJcwNka0qRLm853RRYUQM/5Ctr9DZIyq+iNdGuAECsQTAR3pvlJcZHIM78JMn5r AApI8ZfhZwXdPUXtXQAiDsTicjs+PxW8UI4/BAeTWNfQPSTNuZwOLe9pEN6frJSWdNAR K8F/kPxdSN9iUktFU271EdI3VjgmJ7scrOuByNrU14nmXW8lBNRbvYeW18Z0HlphcGbn AJd4TaVQiiXIqX9m6iNl/sL8PWgFvg6ygjtiTuTTVH0y7kqMX+QdJjqMJeR6L36gwTWV ANR+2RqtLtoYvrZ5rJHAe+jhFpp7X9PZaPt5xrVKbK+PVALrBs/veULC7BBnjWrE+LTk twqw== X-Forwarded-Encrypted: i=1; AJvYcCWW3LAP2a/hLOJ5XRc28sOkU3eOmCJ/WMQmTljOSYpVhqn4jIdvjvL9waUjNsnPyKMwAJFrf3MYnWm3EhI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0HCWb34O5DpW0LftzhL5JsRbd8pa6wCkdch6+OYP4uJ27kJs0 mVgXkPgHdg1dukPxRA7FTenI0x9cXu/3V9f8BKrFxoBqB7ZFCeS6W3nsZTgjgF+hbBxtTKyHHT/ w0eU9u4JDj2d6BqlZpZRejhR2y1LLGP1IWJoRqNDgHu9/QTJiSc3M6odcg7mAlYyceRA= X-Gm-Gg: ASbGncvcveYJfqFAx1+//b2kUI6QvXc2pA7FDqlAdeIbwKgbmfGKF9gm2QrNhmJ4dPg fIJX35jrHmW4QYt+laxc4IQHgznSlE/FwIyjogpNSjz825b9Y8LjIPNaT/cIu+6xKPHglHzEaoD Dg0D28OFFing+jMchOVs/+HeRL8pgNpDFF6lybG9GPpTRwax8Hte1oG8d3BQnCHMOkOlPBYPkLL L8StPJzF4pIPbAw7rz49iAdXH5N9fWupIA3B3sXI84CIdNzPrI8VKonDB4lQaz5Ot4NzTat3BXn 0MAUqYqMIU+4/RQoQx8sDi/19oilXQWnESQFbEpWz0wgbmlggex9cVhmF3tVIYlATiTRB67npnl PbGL68WFJlLl3HdL+Dwq2gAFI3T3LrDIftxAcj8JDBoauV0BvUiHGeIOd X-Received: by 2002:ac8:5d49:0:b0:4ed:6862:cdd0 with SMTP id d75a77b69052e-4edf36e32acmr107293691cf.10.1763382619478; Mon, 17 Nov 2025 04:30:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBfRfdvaplYzbcgQy9VBBUfnsh8fk84DZZU6alhi15KhqLDYHlI0Cttm45o8F/29kkTsiajw== X-Received: by 2002:ac8:5d49:0:b0:4ed:6862:cdd0 with SMTP id d75a77b69052e-4edf36e32acmr107293291cf.10.1763382619031; Mon, 17 Nov 2025 04:30:19 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6433a3d7335sm10133910a12.4.2025.11.17.04.30.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 04:30:18 -0800 (PST) Message-ID: Date: Mon, 17 Nov 2025 13:30:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: msm8939-asus-z00t: add battery To: Erikas Bitovtas , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20251115-battery-hall-v1-0-1586283d17c7@gmail.com> <20251115-battery-hall-v1-1-1586283d17c7@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251115-battery-hall-v1-1-1586283d17c7@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 4WFz2ABxz6Q95dgeE9fW57Oii9QdkDhK X-Authority-Analysis: v=2.4 cv=EIELElZC c=1 sm=1 tr=0 ts=691b155c cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=69Il93vAAAAA:20 a=pGLkceISAAAA:8 a=I6SptnUO25vYt0rnpQ0A:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=bA3UWDv6hWIuX7UZL3qL:22 a=yULaImgL6KKpOYXvFmjq:22 X-Proofpoint-GUID: 4WFz2ABxz6Q95dgeE9fW57Oii9QdkDhK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE3MDEwNSBTYWx0ZWRfX+7SsBp+3ztVg ByHjd+f6kz+b8u8OzRE80q/fn+vrjlryKjwiC89zqEwCVeh+xKuNNxATZkk3pb4I7o/GDPLGqBJ kXUNyVXM4ZzRmz3DOq3cQuXxWl13j3jyzuP/vEgEUH2DX89iTqqf/hSy3Ca/remVL/Kf9rTzge2 a0b6DGfpxQXgBa8m4p8deCITrcu8o9XtGpRt/8QJavR7tSgVQB557ZtM63YzGepCIF++q4Tddxd jUaMP6u69MACJ1OqdRT6kxzMnX3GuuEeDRyVgNGYTyDm+RBFSZrfV2NcgD7VuyKDU2tyOFv087Y Ks70hDK04blwZ9NLUuMhzPuMS53fnNks3Ang4zeOkz5QLmBkR5TgRNmJgAB0p4By5UmXY7bRWyh A0Am1MLs4STcr7ws+0ES3qktebYN1A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_03,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 impostorscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511170105 On 11/15/25 1:26 PM, Erikas Bitovtas wrote: > This device tracks remaining battery capacity percentage using voltage > mode BMS. This commit enables the pm8916_bms node and adds a battery > node to track its capacity. Battery properties were taken from the > downstream code and from the information printed on the battery itself. > > Signed-off-by: Erikas Bitovtas > --- > arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts b/arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts > index ebb548e62e02..b58f0a04abfd 100644 > --- a/arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts > +++ b/arch/arm64/boot/dts/qcom/msm8939-asus-z00t.dts > @@ -20,6 +20,25 @@ aliases { > serial0 = &blsp_uart2; > }; > > + battery: battery { > + compatible = "simple-battery"; > + device-chemistry = "lithium-ion-polymer"; > + voltage-min-design-microvolt = <3400000>; > + voltage-max-design-microvolt = <4400000>; > + energy-full-design-microwatt-hours = <11500000>; > + charge-full-design-microamp-hours = <3000000>; > + > + ocv-capacity-celsius = <25>; > + ocv-capacity-table-0 = <4372000 100>, <4306000 95>, <4247000 90>, > + <4190000 85>, <4134000 80>, <4081000 75>, <4030000 70>, > + <3984000 65>, <3930000 60>, <3884000 55>, <3850000 50>, > + <3826000 45>, <3804000 40>, <3786000 35>, <3770000 30>, > + <3753000 25>, <3734000 20>, <3712000 16>, <3693000 13>, > + <3686000 11>, <3684000 10>, <3682000 9>, <3680000 8>, > + <3676000 7>, <3668000 6>, <3643000 5>, <3600000 4>, > + <3542000 3>, <3462000 2>, <3340000 1>, <3000000 0>; I found a dts for this phone and it seems like there's 3 kinds of batteries which quite obviously have disjoin characteristics https://github.com/Asus-MSM8916/android_kernel_asus_msm8916/blob/10.x/arch/arm/boot/dts/qcom/ASUS_ZE550KL_1936167_3000mAh_3p4COV_VBMS_Final.dtsi https://github.com/Asus-MSM8916/android_kernel_asus_msm8916/blob/10.x/arch/arm/boot/dts/qcom/ASUS_ZE550KL_1949572_3000mAh_3p4COV_VBMS_Final.dtsi https://github.com/Asus-MSM8916/android_kernel_asus_msm8916/blob/10.x/arch/arm/boot/dts/qcom/ASUS_ZE550KL_2024958_3000mAh_120mAcc_3p4COV_VBMS_Final.dtsi I don't think we have a mechanism to handle that in the kernel just yet.. At least documenting which one you based this data on would be nice.. Konrad