From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f100.google.com (mail-ot1-f100.google.com [209.85.210.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 636F248381C for ; Wed, 29 Jul 2026 12:28:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785328140; cv=none; b=tbkeeryDt3RcoqvUK3XrpowrYVYyjAewYqxA3zaeGp4Ng9W7k/lGEfnmW9DzBdCcoeFmUWD32JTn2sKRfXEETqNpXlJ8fxhWhnjXs76pL2Kh/OIeNdy3i8INj5qz9VhFFRW/k/JGZxvpcW9YqepErSiywp2hpGTG0lZrCAP0hEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785328140; c=relaxed/simple; bh=01EyYY3pZm/ZKYc7+9auWJ86XD/LO4jAF5sdui32lI4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lVI1uD466uDo4bEQJ69NWVFg3c9nRxhGoPaH8IwKFud21/QwZSRPTqdG9U0h99G86zZfOS8mACrXxLw7BSrZXK6FdteP6RNlep6fgWL/XQhweJRMdpn5AZdACxBkHEyolxh0grJzzFhK1kdt/x4M02VQxEKhN/W4m56jgZDyM+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=a4lSGCRv; arc=none smtp.client-ip=209.85.210.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="a4lSGCRv" Received: by mail-ot1-f100.google.com with SMTP id 46e09a7af769-7eb42a2f5feso429444a34.1 for ; Wed, 29 Jul 2026 05:28:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785328131; x=1785932931; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=80XIbOpgDfahtQfRx2y5PGslIsS8+OtcUMo3OPdSsEc=; b=FYrH4k/aGkgx1nJgAVGuj7EPa/yfe8IDn1fnlG/ma0zq292bXZyjTlAdnJXrP/HdRs OojklpISVu5D9hJ4zQL2nrMTGTodsOY6uqhJtYbnKVIXNKJC1L61+26kHa5m0IyteXJJ AEXXl5oqDVA2PKBnfXPvknzmBgfzasVnBTcwYsyp3oTmGwe+gHWXM2HNXcHbZriuZuPj bnj38FPiam0foRobFbir9dtqZRqERowTzlZAkBiBMNesa9fQqj7vM1/d8ljXuGr2SZ4o YfLzKE9oNxyu6VgbzXGgPCkxmR2EJAozgQrJOH8ESADeIcpfSLYLSIe+n4aktFUA6gg5 XRfA== X-Forwarded-Encrypted: i=1; AHgh+RqzneD04gL9ydGjh97FtdRSKBkzx/8oJbk+HU/PrgGIpyP4sZzOkWVNI9Na/Te2h/yweZUVpqIxm3K9jvI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3RQuIxP2+0Ai52B8SSW9koFKZc83CQMs42209tLVBywUxdi3U IYLOt3rPdG7eXKWD0uQk4PZR5xH9fHnaXM0HqUCRgXJr+TKoZ+qtDx6BsCXtmSFCb8ImflDBQPG VY1EWXMr8Soigql75xpIreTyz9gUkGO/UAMw9r7+HE0iO7jjaz43FcIZ2sgLX0wxNN4MzHYIVx9 JvOMH/+NKpVOuD/JjO6P+72UMl5unuvij1sUqnf1/WEoLcAys5xItLswwhMM2WsEucrt8I04MeZ QV6ofFAM/LUkqh4VXs/bQPzWw== X-Gm-Gg: AR+sD13hEIV1C+wHyVlSItIM4167WHKD9Wky6xtAQKl96du+sh13vxEKzjaPeK7vZ/R +qq+58oll0S5aniRbbmVZacWc+XXDWf0oht+92MU36EcKu33YQpzVm6MZ45P/vgF63uxm3XFomK 0GzvR8OvzXeTNIqzYaOwyyE1ODe0edG24rIoJUjSVK7UzNNK9kKqILHUNPktaMkL+G5LObeD4bu NMuiX1i9XvY/FYREiA2tnjOzt3NrpuX477279pg4d++Lhu+7RLF56OvkSO5Wa50Th5GqNlSTD2T /CpALfRwIupQayObiOe277+69VdGVYz8/3FNT6vX3AC73dFjxGke//kdxVUJYk6lpOu2hvz62Wp JtM8ouVWIoUjV5DkUhagamqEWCG7je198vf0GADv91bKJKrW1Z/SmsTwpRdzK0fGjr7fDovWp5v e6UOGOTooSbqF4Vv8UPTFHE/TrjRi9ypU1Qjl8VZw= X-Received: by 2002:a05:6830:3495:b0:7ed:ceed:95b9 with SMTP id 46e09a7af769-7efff0eb73dmr4056525a34.32.1785328131455; Wed, 29 Jul 2026 05:28:51 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-73.dlp.protect.broadcom.com. [144.49.247.73]) by smtp-relay.gmail.com with ESMTPS id 46e09a7af769-7f00d2df245sm193055a34.0.2026.07.29.05.28.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jul 2026 05:28:51 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-c15dfd34e4cso73358866b.0 for ; Wed, 29 Jul 2026 05:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1785328130; x=1785932930; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=80XIbOpgDfahtQfRx2y5PGslIsS8+OtcUMo3OPdSsEc=; b=a4lSGCRvxaWOQD7EffhlSaJ0LvgSD5SvyHupbGgl026P4e4zD+vEJo1ssY2Lp6030k zxco6exJrJe/Ux3TpdU2EuDLWksK8bx76C4aWGfU8SZyabtSdVXMLy0/OmS4S0WJZZPQ CPmPcfBFqneTaX5tnLwWYrXKPblnLLjOdKGH0= X-Forwarded-Encrypted: i=1; AHgh+RrUe6zI3Wx9fGropfHwO++wGkOarmwNig/GPGxJJWwXVzp5WKYzvPILLh5H+JqWf2k+3v8qvLGE+Sg7AyI=@vger.kernel.org X-Received: by 2002:a17:906:99cb:b0:c1f:2b07:55aa with SMTP id a640c23a62f3a-c1f7218e1a2mr327886966b.45.1785328129633; Wed, 29 Jul 2026 05:28:49 -0700 (PDT) X-Received: by 2002:a17:906:99cb:b0:c1f:2b07:55aa with SMTP id a640c23a62f3a-c1f7218e1a2mr327885066b.45.1785328129208; Wed, 29 Jul 2026 05:28:49 -0700 (PDT) Received: from [10.176.3.215] ([192.19.176.250]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1f83fabc2fsm105876966b.50.2026.07.29.05.28.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 05:28:48 -0700 (PDT) Message-ID: Date: Wed, 29 Jul 2026 14:28:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: brcmfmac: configure SAE PWE method for external SAE AP To: Bogdan Nicolae Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org References: <20260729053408.13715-1-bogdan.nicolae@gmail.com> <5cf57b2d-2bcc-481c-87bf-3a034d5f99be@broadcom.com> Content-Language: en-US From: Arend van Spriel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 29/07/2026 13:48, Bogdan Nicolae wrote: >> On Wed, Jul 29, 2026, 04:48 Arend van Spriel >> > wrote: >> >> On 29/07/2026 07:34, Bogdan Nicolae wrote: >> > When bringing up a WPA3-SAE SoftAP with external (user space) >> SAE, the >> > driver never told the firmware which SAE Password Element (PWE) >> method to >> > accept. The firmware was observed to corrupt its heap over time >> due to >> > this omission, leading to firmware trap (data abort in heap >> allocator). >> > >> > Parse the beacon IEs on start_ap() and set the extsae_pwe iovar >> > accordingly: 2 when the RSNX IE advertises H2E, 1 when an H2E-only >> > membership selector is present, 0 otherwise. This matches the >> behaviour >> > of the upstream/vendor driver and only applies to SAE-capable APs >> when >> > external SAE is supported. >> >> This makes sense, but may I ask what device do you have? Suspect it >> is a >> Cypress/Infineon chip. I could not find the iovar in our (Broadcom bca) >> code base so I suspect it is vendor specific. > Hi Arend, > > Indeed, this is a bcm43455 as found on Raspberry Pi SoCs. Than we should only invoke the parse function for cyw vendor. Regards, Arend