From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Drew Fustini <dfustini@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Dave Gerlach <d-gerlach@ti.com>, Tony Lindgren <tony@atomide.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: wkup-m3-ipc: Add vtt toggle bindings
Date: Sat, 9 Apr 2022 18:25:24 +0200 [thread overview]
Message-ID: <c4536b89-4843-c669-e499-f82fa3fec7f8@linaro.org> (raw)
In-Reply-To: <20220409045145.2434096-2-dfustini@baylibre.com>
On 09/04/2022 06:51, Drew Fustini wrote:
> Document the Wakeup M3 IPC properties that can be used to toggle the VTT
> regulator during low power mode transitions.
>
(...)
> @@ -51,6 +61,15 @@ properties:
> mbox_wkupm3 child node.
> maxItems: 1
>
> + ti,needs-vtt-toggle:
> + type: boolean
> + description: boards requires VTT toggling during suspend/resume
> +
> + ti,vtt-gpio-pin:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: pin on the GPIO0 module used for VTT toggle
> + maxItems: 1
No need for maxItems, it's a single uint32. You could add "maximum" if
you know the constraints for the value.
Do you actually need two properties (bool + pin)? A case of
"ti,vtt-gpio-pin" without the "ti,needs-vtt-toggle" is valid?
The other way looks wrong, so you need to add a dependency (see
example-schema).
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-09 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 4:51 [PATCH 0/2] soc: ti: wkup_m3_ipc: support vtt toggle Drew Fustini
2022-04-09 4:51 ` [PATCH 1/2] dt-bindings: wkup-m3-ipc: Add vtt toggle bindings Drew Fustini
2022-04-09 16:25 ` Krzysztof Kozlowski [this message]
2022-04-09 20:37 ` Drew Fustini
2022-04-12 16:09 ` Rob Herring
2022-04-09 4:51 ` [PATCH 2/2] soc: ti: wkup_m3_ipc: Add support for toggling VTT regulator Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4536b89-4843-c669-e499-f82fa3fec7f8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dfustini@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®