From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E65B2C04A68 for ; Thu, 28 Jul 2022 11:24:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236952AbiG1LYj (ORCPT ); Thu, 28 Jul 2022 07:24:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236948AbiG1LYU (ORCPT ); Thu, 28 Jul 2022 07:24:20 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6024867CB9; Thu, 28 Jul 2022 04:21:47 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 49FEE6601B43; Thu, 28 Jul 2022 12:21:45 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1659007305; bh=cQKa4cD8+Dc8uivpLk6aRVwpns1CsSwbo+ldgdagj1g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WSBPIdgbeM9yM9T8Rey7+jygYbHH7L6TwPmQFrJ3SlBTQwx4Lo3qnurhN8zy2+Fef TsObUv0p9KZHI2pRs72OVlwWSSgOPKBBE/qsNnVhPK2JZsEHCQL5VsTgW2ySr4Abio dAhGWWa1Al86qwOxaZbTiYKSmrmu/H/vcqUMzFUSt7p4c+2VFjVFka8DasdqPBVsAP OAK8xoAQp+4IyIjtszy1/Tw2Bmfjd66nZzwtQYFsJSAyuOGTSxNUNtPJm1EwxSsuFE /dUpJxahzl/ZhGPMrh5FHxvUwkghSbY2tTBAgxmFrS+QzebY8hsamBrHTAjGRALmwG sqxJNc8hVyi7Q== Message-ID: Date: Thu, 28 Jul 2022 13:21:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] arm64: dts: mt8173-oak: Switch to SMC watchdog Content-Language: en-US To: Pin-yen Lin , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Eizan Miyamoto , Hsin-Yi Wang , Evan Benn , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org References: <20220727094034.1372745-1-treapking@chromium.org> From: AngeloGioacchino Del Regno In-Reply-To: <20220727094034.1372745-1-treapking@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 27/07/22 11:40, Pin-yen Lin ha scritto: > Switch to SMC watchdog because we need direct control of HW watchdog > registers from kernel. The corresponding firmware was uploaded in > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405. > > Signed-off-by: Pin-yen Lin > --- > > Changes in v2: > - Move the modifications to mt8173-elm.dtsi and add some comments. > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > index e21feb85d822..b2269770abc3 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > @@ -161,6 +161,18 @@ hdmi_connector_in: endpoint { > }; > }; > }; > + > + soc { > + /* > + * Disable the original MMIO watch dog and switch to the SMC watchdog, > + * which operates on the same MMIO. > + */ > + /delete-node/ watchdog@10007000; Unfortunately, we're not quite there yet. The comment is fine, but... There's no need to /delete-node/: you can just do it like /* * Disable the original MMIO watch dog and switch to the SMC watchdog, * which operates on the same MMIO. */ &watchdog { status = "disabled"; }; and... > + > + watchdog { This isn't addressable, hence it belongs to the root node, not to soc. If you did that because of naming issues, I would propose to call it smc-watchdog instead of watchdog. > + compatible = "arm,smc-wdt"; P.S.: No timeout-sec? Regards, Angelo > + }; > + }; > }; > > &mfg_async { >