mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Akash Goel <akash.goel@arm.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: "Adrián Larumbe" <adrian.larumbe@collabora.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Steven Price" <steven.price@arm.com>,
	kernel@collabora.com, "Liviu Dudau" <liviu.dudau@arm.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>
Subject: Re: [PATCH] drm/panthor: Support partial unmaps of huge pages
Date: Wed, 22 Oct 2025 05:55:23 +0100	[thread overview]
Message-ID: <c4639586-1bf0-4571-9e45-707fe7e7ba58@arm.com> (raw)
In-Reply-To: <20251021180938.7a674618@fedora>



On 10/21/25 17:09, Boris Brezillon wrote:
> On Tue, 21 Oct 2025 15:32:45 +0100
> Akash Goel <akash.goel@arm.com> wrote:
> 
>> On 10/19/25 04:19, Adrián Larumbe wrote:
>>> Commit 33729a5fc0ca ("iommu/io-pgtable-arm: Remove split on unmap
>>> behavior") did away with the treatment of partial unmaps of huge IOPTEs.
>>>    
>>
>> Sorry have a doubt.
>>
>> Corresponding to the commit 33729a5fc0ca, can we now remove the code to
>> pre-allocate L3 page table pages i.e. 'op_ctx->rsvd_page_tables.pages'
>> inside panthor_vm_prepare_unmap_op_ctx() ?.
> 
> Well, not if we want to support partial unmaps of huge pages at a non-2M
> boundary.

Thanks Boris for clarifying.

Sorry I didn't consider that in order to support partial unmaps of huge 
pages at a non-2M boundary, we still need to call panthor_vm_map_pages() 
so as to remap the difference between the start/end of huge page and the 
start/end of the actual unmap range.

Best Regards
Akash



  reply	other threads:[~2025-10-22  4:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-19  3:19 Adrián Larumbe
2025-10-21 14:32 ` Akash Goel
2025-10-21 16:09   ` Boris Brezillon
2025-10-22  4:55     ` Akash Goel [this message]
2025-10-21 17:39   ` Adrián Larumbe
2025-10-22  4:45     ` Akash Goel
2025-10-22  9:05       ` Adrián Larumbe
2025-10-22 11:04         ` Adrián Larumbe
2025-10-21 14:42 ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4639586-1bf0-4571-9e45-707fe7e7ba58@arm.com \
    --to=akash.goel@arm.com \
    --cc=adrian.larumbe@collabora.com \
    --cc=airlied@gmail.com \
    --cc=boris.brezillon@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=steven.price@arm.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®