From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6777C3C9EE2 for ; Thu, 19 Mar 2026 11:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773920442; cv=none; b=u1nfewet29YZt7mkS3e+QhVYcdJTyiVp8hkihAmXm25s1Eve1ZiFUDpFcyOjTpfGd2n8Z1sTWWYz3Wrz+OW/EgyNbFyqJrShLYE+Dyz/MymhUoFwAWfH9sxe6w+emb9HfeuFaXQl4E+Qm8UMzgqpwCrRcZrqcMt9531xp/t2hPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773920442; c=relaxed/simple; bh=8lvV+05AjlYqBRAnsrePyYBoV0IAotltEMTqGo97B70=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l44aOG0BjH0gggeeSfPEwe2MhFXfk7QYZyYy1bJk1tpZ58BJJnQeYIaYb3rGghGgmqTOjK4dqiax8ZUa/FDXQ8rRHrEKqGh3NYkcgJ7VyLJ7BH8RCEcAQRl8Gy0h4Q0CkPtfGAM3uZ9MeB2j2QoAPpOEVgYxT5K+QwzBJjxMq1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DHbrJsk4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q0lU6r31; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DHbrJsk4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q0lU6r31" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62J73wwj3771115 for ; Thu, 19 Mar 2026 11:40:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /pd4kfXQuTMgtemwulqYBe2gk/xcEWWLvTi2fWAaQ48=; b=DHbrJsk4P+gG48u0 Gl13B3CVu++m3kks+dwIes8uGTLH3/vXUjscG57yArDDOo7qVUEnW2SRcY3zvHfm 6mQMg1WbplKIu9+LgKSIHmzWnoEbJtR7pN2/Wkh5gLkWZxP3kdAHzQhzJNWcYMCt vwoGw+yU7SkT+WFKgwl9JtqAG2dLjHNI8cWJoWoOb1FmDCsRfwcJuEscYu/pCo3g mdKq7F4CngIJHI8aT+yPg7Jr4hFZ1ccEXcj0rr/9PoA6zxeeqMZNlrgn8KsLaMu5 sGqTuP7VR3VFKsl8lgaz4uZ3rWh2lz9q9lpnPVlC/bcu4FFlCMIw70xzY+yxsXsr POUDhg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d083r9jbb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Mar 2026 11:40:29 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-89a012f8ab7so7783676d6.2 for ; Thu, 19 Mar 2026 04:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773920428; x=1774525228; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/pd4kfXQuTMgtemwulqYBe2gk/xcEWWLvTi2fWAaQ48=; b=Q0lU6r31dfQDpVCCugcqTGJDeb2iLzduA3aObrOn0j7osxBkYX17wfnMj9888Vi6Au IBO8QJ9CnTmbfq4c+zs6o9ZXqGmxh3S2HccpCCHd8oXne7ERGbklmRF5ngQ/cgQ0KNCg pBDe2Ab9K+pIiRMLENKxSKFNJ2k3S9Aylx/kT4UqEoS/se4ViSFs6jXnaIUpqRVo4Czw gRsyg+oxa8au6BHMXirRNbiQRhBhvvbLvoZ/q5FNyJCTHoQV7V+RTsuVIIkZw+ArmqHH csSLhYiaOkTKKlaF6N13nH6PbRjn/ZZZQ1ZRFXbZrjdPfAuHS0WP0pTu43teVArEBJgt UilQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773920428; x=1774525228; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/pd4kfXQuTMgtemwulqYBe2gk/xcEWWLvTi2fWAaQ48=; b=dL1lo3SLiO5hyWCiU5xRBXJdcrexWUrdgkJeQvofxTORHP02ZrNRmsQSyOFFtoFo9e TTOeCJR6yctKoYCgegzf1oj3agm9d1xz3vxRy/7fxpe8M/DtmWWCGlbtI4Z55Va2BP8k c9gdXBBJ9KT5Q11dq8cHQ1CgtywQbch7PtjpyQWUJSD8hUj8IhvY195LovyAd9IM0HRL Wh2w62svM2d4LsXawBAMDhzHNNq69TkF6E/3u8x/AhE7WdFUdJi5D+XKg+T6U6BuAt2A WIZb6qlvdUq6dMpz1WxKlLrisjuI3a5FWFj8rHh3JQcr/i4SbYV8A0wb11br+1YOWNw1 31jA== X-Forwarded-Encrypted: i=1; AJvYcCVPUKzQ7c1RCHkzc4vxFd4kVpYE+cgTJUiFkcf83KkC+O4/EyH4OhjOo1i7zMHT10K8mNNSsKuzM1Ud8n8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzgdv3xr8ADF7C6Givcc2w18iQaL/yUDsMtd8Yeyn0/7ULi7Rtd aTk6xcMHVWAY9r67L0rB2xvMKLckCjoJOgZR803cl4PiqvzqK6c35sn7Jm2r2NeMG5OobbXSVOQ cKVTIZFqc0KlnzUgChM2dxR0uUY2TDH3AFilpG+/02it6CZAEIYLzL+ToBVM5DLEvlHc= X-Gm-Gg: ATEYQzwuKDbBlOYul87ApEhZVCgWpCxDCAB6o/Ugjk/xhcSpAYGTnuTkI8VBF7cej9Y EZ503Go+Qx0GP9Z1XuofdVMs82LxUJ0ljq57HzcHZ47jWy6NvEiSe874nW9buSYvUbCU3itHABP hOUcNZnYqVeenvGv3bB5hGNx+MoVLXckMCbbnP6yfZQ3DOWO/3nmRnuH0ERBw0uzcHR0Iq+Z7H9 U2HVOXCuCWjNiANhri6bSTp5sNSqAET1aX9Lj6lvOFVHIfS2/oKSPTMCLhJkgBEUEjGrAZkzYpT 4IwBoTQxmK1l17TyAU3rNX+v6U7xrDaTCCsp/knI2zxv9BS8HCglfBuH2ZJ6JAgqe1Nu59/zHjV azYOMnS+n49K29CTEcWGpRLduRO4ifGeqiZUl18arjTVXNt/E83WY9oa04qeguLu0wnZ492qUVB Xy7zk= X-Received: by 2002:ad4:594c:0:b0:89c:4aae:408f with SMTP id 6a1803df08f44-89c6b580401mr79493256d6.5.1773920428094; Thu, 19 Mar 2026 04:40:28 -0700 (PDT) X-Received: by 2002:ad4:594c:0:b0:89c:4aae:408f with SMTP id 6a1803df08f44-89c6b580401mr79492886d6.5.1773920427675; Thu, 19 Mar 2026 04:40:27 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f142adf1sm430583866b.16.2026.03.19.04.40.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 04:40:26 -0700 (PDT) Message-ID: Date: Thu, 19 Mar 2026 12:40:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] arm64: dts: qcom: Add AYN QCS8550 Common To: webgeek1234@gmail.com, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Teguh Sobirin References: <20260311-ayn-qcs8550-v2-0-e66986e0f0cb@gmail.com> <20260311-ayn-qcs8550-v2-2-e66986e0f0cb@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260311-ayn-qcs8550-v2-2-e66986e0f0cb@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 8X7CglzAr6Ip8uuC2Xfd2LBYTBq2xMAh X-Proofpoint-ORIG-GUID: 8X7CglzAr6Ip8uuC2Xfd2LBYTBq2xMAh X-Authority-Analysis: v=2.4 cv=ApTjHe9P c=1 sm=1 tr=0 ts=69bbe0ad cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=B-J4ztEYYRmK9Gd1W5QA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE5MDA5NCBTYWx0ZWRfX9Jd1q1TMocFG 2zCPMrduFDHxpUH6LW5zGmRDLNKCcy76CRhUyv6NR+5Ea9YQHpoXFXXrxXtiI7TJHF+kJWF50cH iffpriaP41Tnl7dkIz1wCjcR1KDozkb+CGqJ+dpiWR6PcgwGBECyVlYLAjE4S0yhKPQg9+KM7BS KPovDIUhBN6QfQMzIojpdctSxf3ZcbmfBOhE+cmoQiK+gIuagXjZ9ZVybn4rxwybzaQVS4uCVLx 5rG9YD9xYDDv/jxdSVWZf6xAGciqSKwarp8sY87JifN/+DIiD13AqnXc17bZNkXOh7dK/fVwcRh Mt/GTIUISxvvuT+NR8fzVI56pBJfDireXQBJbm1gK3AFM/hMOqfmui2IfawxFVVdCwcoph9vg7h vUc5ubeBysu7Sj+cdslCKg1XdN024dcHtVqFYRdzs6hTU+ORvq4DP9d3Fzku7hvG49RVGVhKu0y FO/1VywGd0bBTXw9mFQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-19_01,2026-03-19_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 suspectscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603190094 On 3/11/26 6:44 PM, Aaron Kling via B4 Relay wrote: > From: Teguh Sobirin > > This adds a base dtb of everything common between the AYN QCS8550 > devices. It is intended to be extended by device specific overlays. > > Signed-off-by: Teguh Sobirin > Co-developed-by: Aaron Kling > Signed-off-by: Aaron Kling > --- [...] > + pwm_fan: pwm-fan { > + compatible = "pwm-fan"; > + > + fan-supply = <&vdd_fan_5v0>; > + pwms = <&pm8550_pwm 3 50000>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&fan_pwm_active>, <&fan_int>; property-n property-names in this order, everywhere, please > + > + pulses-per-revolution = <4>; > + interrupt-parent = <&tlmm>; > + interrupts = <13 IRQ_TYPE_EDGE_FALLING>; interrupts-extended = <&tlmm 13 IRQ_...>; [...] > + model = "AYN-Odin2"; > + audio-routing = > + "IN1_HPHL", "HPHL_OUT", Let's drop this empty linebreak > + "IN2_HPHR", "HPHR_OUT", > + "AMIC2", "MIC BIAS2", > + "TX SWR_INPUT1", "ADC2_OUTPUT"; > + > + speaker-i2s-dai-link { > + link-name = "Primary MI2S Playback"; > + > + cpu { > + sound-dai = <&q6apmbedai PRIMARY_MI2S_RX>; > + }; 'co'dec < 'cp'u, please resort [...] > + vdd_fan_5v0: vdd-fan-5v0-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vdd_fan_5v0"; > + > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + > + gpio = <&tlmm 109 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&fan_pwr_active>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; oh, I didn't know this binding existed.. but it seems valid indeed! [...] > +&i2c12 { > + clock-frequency = <400000>; > + status = "okay"; Let's uniformly keep a \n before status > +}; > + > +&i2c_master_hub_0 { > + status = "okay"; Please add a clock-frequency (you can read it back at runtime running a vendor kernel if you don't have a better source) [...] > + spk_amp_l: spk_amp_l@34 { underscores are no bueno in node names (between ':' and '@'), and they should be generic, let's try amplifier@ [...] > +&iris { > + status = "okay"; firmware-name? [...] > +&sdhc_2 { > + cd-gpios = <&pm8550_gpios 12 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_default &sdc2_card_det_n>; > + pinctrl-1 = <&sdc2_sleep &sdc2_card_det_n>; > + vmmc-supply = <&vreg_l9b_2p9>; > + vqmmc-supply = <&vreg_l8b_1p8>; > + max-sd-hs-hz = <37500000>; It's already in 8550.dtsi, you can drop it > + no-sdio; > + no-mmc; > + > + qcom,dll-config = <0x0007442c>; Is that changed in your downstream tree? [...] > +&swr1 { > + status = "okay"; > + wcd_rx: codec@0,4 { Let's keep a \n between properties and the subsequent subnodes, also file-wide [...] > +&tlmm { > + gpio-reserved-ranges = <32 8>; > + > + dsi_p_rst_active: dsi-p-rst-active-state { > + pins = "gpio133"; https://docs.kernel.org/devicetree/bindings/dts-coding-style.html Let's order them by the pin index (it's a fairly new development so other 8550 devices don't really have that) [...] > +&usb_dp_qmpphy { > + vdda-phy-supply = <&vreg_l3e_1p2>; > + vdda-pll-supply = <&vreg_l3f_0p88>; > + > + mode-switch; Already present in sm8550.dtsi Konrad