mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Magnus Lindholm <linmag7@gmail.com>,
	linux-i2c@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-alpha@vger.kernel.org
Cc: andi.shyti@kernel.org, wsa+renesas@sang-engineering.com
Subject: Re: [PATCH] i2c: i2c-elektor: Allow building on SMP kernels
Date: Sat, 22 Nov 2025 14:29:49 +0100	[thread overview]
Message-ID: <c468dc2e6f5c4ea132f2bf25e6d6976e0c317005.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <20251122122846.28493-1-linmag7@gmail.com>

Hi Magnus,

On Sat, 2025-11-22 at 13:26 +0100, Magnus Lindholm wrote:
> It the past the i2c-elektor driver has been broken on SMP, as it seems

Typo: s/It/In/ and I think there should be a full stop after "SMP".

> there has since been some fixes/cleanup work to get rid of cli/sti and

s/has/have/

> rely on spinlocks instead (as pointed out by Wolfram Sang). Tested this

The sentence just ends after "instead". I think you meant to say "instead,
let's allow building the driver on SMP kernels again." or something like
that.

> driver on SMP kernel on Alpha/UP2000+ for a few days without any problems.
> 
> Signed-off-by: Magnus Lindholm <linmag7@gmail.com>
> ---
>  drivers/i2c/busses/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index fd81e49638aa..9b1473d720a0 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -1474,7 +1474,7 @@ config I2C_ACORN
>  
>  config I2C_ELEKTOR
>  	tristate "Elektor ISA card"
> -	depends on ISA && HAS_IOPORT_MAP && BROKEN_ON_SMP
> +	depends on ISA && HAS_IOPORT_MAP
>  	select I2C_ALGOPCF
>  	help
>  	  This supports the PCF8584 ISA bus I2C adapter.  Say Y if you own

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

  reply	other threads:[~2025-11-22 13:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-22 12:26 Magnus Lindholm
2025-11-22 13:29 ` John Paul Adrian Glaubitz [this message]
2025-11-22 13:51   ` Magnus Lindholm
2025-11-24 20:49   ` Maciej W. Rozycki
2025-11-24 22:42     ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c468dc2e6f5c4ea132f2bf25e6d6976e0c317005.camel@physik.fu-berlin.de \
    --to=glaubitz@physik.fu-berlin.de \
    --cc=andi.shyti@kernel.org \
    --cc=linmag7@gmail.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®