From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751318AbdK0CUc (ORCPT ); Sun, 26 Nov 2017 21:20:32 -0500 Received: from regular1.263xmail.com ([211.150.99.131]:57545 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbdK0CUb (ORCPT ); Sun, 26 Nov 2017 21:20:31 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: hjc@rock-chips.com X-FST-TO: sandy.huang@rock-chips.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: hjc@rock-chips.com X-UNIQUE-TAG: <5ea4f65a8ff6fbb49b1a2642eae23fa3> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Sandy Huang To: Vasyl Gomonovych Cc: linux-kernel@vger.kernel.org, airlied@linux.ie, heiko@sntech.de, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] drm/rockchip: dma-mapping: Use vma_pages helper References: <1511364247-8581-1-git-send-email-gomonovych@gmail.com> Message-ID: Date: Mon, 27 Nov 2017 10:20:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1511364247-8581-1-git-send-email-gomonovych@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, this update has merged to drm-misc-next months ago: https://patchwork.freedesktop.org/patch/178255/ 在 2017/11/22 23:24, Vasyl Gomonovych 写道: > Use vma_pages function on vma object instead of explicit computation. > ./drivers/gpu/drm/rockchip/rockchip_drm_gem.c:223:34-40: WARNING: Consider using vma_pages helper on vma > Generated by: scripts/coccinelle/api/vma_pages.cocci > > Signed-off-by: Vasyl Gomonovych > --- >   drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +- >   1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > index 1869c8bb76c8..1d9655576b6e 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_iommu(struct drm_gem_object *obj, >   { >       struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); >       unsigned int i, count = obj->size >> PAGE_SHIFT; > -    unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > +    unsigned long user_count = vma_pages(vma); >       unsigned long uaddr = vma->vm_start; >       unsigned long offset = vma->vm_pgoff; >       unsigned long end = user_count + offset; >