From: Guenter Roeck <linux@roeck-us.net>
To: Huibin Shi <henrys@silicom-usa.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Henry Shi <henryshi2018@gmail.com>,
"hbshi69@hotmail.com" <hbshi69@hotmail.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"markgross@kernel.org" <markgross@kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Cc: "hb_shi2003@yahoo.com" <hb_shi2003@yahoo.com>,
Wen Wang <wenw@silicom-usa.com>
Subject: Re: [PATCH] Add Silicom Platform Driver
Date: Tue, 8 Aug 2023 12:35:30 -0700 [thread overview]
Message-ID: <c46e24e0-b054-e59f-34bc-e5ddcb93b6d8@roeck-us.net> (raw)
In-Reply-To: <PA4PR04MB922285C2DC1BB0BDBDD602B39A0DA@PA4PR04MB9222.eurprd04.prod.outlook.com>
On 8/8/23 12:19, Huibin Shi wrote:
> Guenter,
>
> Here is the implementation of devm_kmemdup(), *src is the extra argument
>
> void *devm_kmemdup(struct device *dev, const void *src, size_t len, gfp_t gfp)
> {
> void *p;
>
> p = devm_kmalloc(dev, len, gfp);
> if (p)
> memcpy(p, src, len);
>
> return p;
> }
>
So you don't want to use devm_kmemdup() because of its 'src' argument, and instead
re-implement it locally by using devm_kzalloc() followed by memcpy() ? Really ?
Guenter
next prev parent reply other threads:[~2023-08-08 20:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 16:01 Henry Shi
2023-07-18 16:40 ` Guenter Roeck
2023-07-25 20:29 ` Huibin Shi
2023-07-19 12:13 ` Ilpo Järvinen
2023-07-28 19:10 ` Huibin Shi
2023-08-03 12:06 ` Ilpo Järvinen
2023-08-10 17:48 ` Huibin Shi
2023-08-10 18:00 ` Guenter Roeck
2023-08-14 13:07 ` Huibin Shi
2023-08-10 18:01 ` Guenter Roeck
2023-08-14 13:09 ` Huibin Shi
2023-07-25 21:02 ` Christophe JAILLET
2023-07-28 12:59 ` Huibin Shi
2023-07-28 14:28 ` Guenter Roeck
2023-08-08 19:19 ` Huibin Shi
2023-08-08 19:35 ` Guenter Roeck [this message]
2023-08-08 20:39 ` Huibin Shi
2023-07-28 16:47 ` Christophe JAILLET
2023-07-28 17:52 ` Guenter Roeck
2023-08-08 19:23 ` Huibin Shi
2023-08-15 13:37 Henry Shi
2023-08-17 8:06 ` Ilpo Järvinen
2023-08-18 14:31 ` Huibin Shi
2023-08-18 15:43 Henry Shi
2023-08-19 12:41 ` Guenter Roeck
2023-08-19 14:20 ` Huibin Shi
2023-08-19 14:36 ` Guenter Roeck
2023-08-21 10:39 ` Ilpo Järvinen
2023-08-21 16:00 ` Huibin Shi
2023-08-21 15:48 ` Huibin Shi
2023-08-21 16:09 ` Guenter Roeck
2023-08-21 16:23 ` Huibin Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c46e24e0-b054-e59f-34bc-e5ddcb93b6d8@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bp@alien8.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dave.hansen@linux.intel.com \
--cc=hb_shi2003@yahoo.com \
--cc=hbshi69@hotmail.com \
--cc=hdegoede@redhat.com \
--cc=henrys@silicom-usa.com \
--cc=henryshi2018@gmail.com \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wenw@silicom-usa.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®