From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E470C7EE23 for ; Tue, 23 May 2023 08:19:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235973AbjEWITj (ORCPT ); Tue, 23 May 2023 04:19:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235662AbjEWISz (ORCPT ); Tue, 23 May 2023 04:18:55 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E1A21701; Tue, 23 May 2023 01:17:00 -0700 (PDT) Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QQRrG6JSjz18LfT; Tue, 23 May 2023 16:12:30 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 16:16:58 +0800 Subject: Re: [PATCH net] page_pool: fix inconsistency for page_pool_ring_[un]lock() To: Jesper Dangaard Brouer , Ilias Apalodimas CC: , , , , , , Jesper Dangaard Brouer , Eric Dumazet , Lorenzo Bianconi , Daniel Borkmann , John Fastabend References: <20230522031714.5089-1-linyunsheng@huawei.com> <1fc46094-a72a-f7e4-ef18-15edb0d56233@redhat.com> From: Yunsheng Lin Message-ID: Date: Tue, 23 May 2023 16:16:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/5/23 15:08, Jesper Dangaard Brouer wrote: > On 23/05/2023 04.13, Yunsheng Lin wrote: >> Do you still working on optimizing the page_pool destroy >> process? If not, do you mind if I carry it on based on >> that? > > I'm still working on improving the page_pool destroy process. > I prefer to do the implementation myself. Sure, let me know if you want a hand for that. > > I've not submitted another version, because I'm currently using the > workqueue to detect/track a memory leak in mlx5. > > The mlx5 driver combined with XDP redirect is leaking memory, and will > eventually lead to OOM. The workqueue warning doesn't point to the > actual problem, but it makes is easier to notice that there is a problem. > > --Jesper > > . >