From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Nicolai Buchwitz <nb@tipi-net.de>
Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
n.buchwitz@kunbus.com, p.rosenberger@kunbus.com,
stable@vger.kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: dev: can_set_termination(): Allow gpio sleep
Date: Thu, 21 Nov 2024 16:17:53 +0100 [thread overview]
Message-ID: <c47b3d06-8763-4f69-b845-c7b58c9e2fd2@kunbus.com> (raw)
In-Reply-To: <20241121-augmented-aquamarine-cuckoo-017f53-mkl@pengutronix.de>
Hi,
On 21.11.24 16:12, Marc Kleine-Budde wrote:
> Hello Nicolai,
>
> thanks for your contribution!
>
> On 21.11.2024 16:02:09, Nicolai Buchwitz wrote:
>> The current implementation of can_set_termination() sets the GPIO in a
>> context which cannot sleep. This is an issue if the GPIO controller can
>> sleep (e.g. since the concerning GPIO expander is connected via SPI or
>> I2C). Thus, if the termination resistor is set (eg. with ip link),
>> a warning splat will be issued in the kernel log.
>>
>> Fix this by setting the termination resistor with
>> gpiod_set_value_cansleep() which instead of gpiod_set_value() allows it to
>> sleep.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
>
> I've send the same patch a few hours ago:
>
> https://lore.kernel.org/all/20241121-dev-fix-can_set_termination-v1-1-41fa6e29216d@pengutronix.de/
>
> Marc
>
Shouldnt this also go to stable?
Regards,
Lino
next prev parent reply other threads:[~2024-11-21 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 15:02 Nicolai Buchwitz
2024-11-21 15:12 ` Marc Kleine-Budde
2024-11-21 15:17 ` Lino Sanfilippo [this message]
2024-11-21 15:25 ` Marc Kleine-Budde
2024-11-21 15:30 ` Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c47b3d06-8763-4f69-b845-c7b58c9e2fd2@kunbus.com \
--to=l.sanfilippo@kunbus.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=n.buchwitz@kunbus.com \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=p.rosenberger@kunbus.com \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®