From: Andrew Lunn <andrew@lunn.ch>
To: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
longli@microsoft.com, kotaranov@microsoft.com, horms@kernel.org,
mhklinux@outlook.com, pasha.tatashin@soleen.com,
kent.overstreet@linux.dev, brett.creeley@amd.com,
schakrabarti@linux.microsoft.com,
shradhagupta@linux.microsoft.com, ssengar@linux.microsoft.com,
leon@kernel.org, rosenp@gmail.com, paulros@microsoft.com,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 1/3] net: mana: Add speed support in mana_get_link_ksettings
Date: Mon, 21 Apr 2025 14:36:43 +0200 [thread overview]
Message-ID: <c481c8a8-4e0f-4498-89f9-988673a584f6@lunn.ch> (raw)
In-Reply-To: <1745217220-11468-2-git-send-email-ernis@linux.microsoft.com>
On Sun, Apr 20, 2025 at 11:33:38PM -0700, Erni Sri Satya Vennela wrote:
> Add support for speed in mana ethtool get_link_ksettings
> operation. This feature is not supported by all hardware.
This needs a lot more justification. tc(1) will show you the current
HTB Qdisc setting. No other MAC driver i know of will show you Qdisc
info in ksettings. So why is mana special?
Something your said in an earlier thread might be relevant here. There
are two shaper settings involved. The Hypervisor can configure a
limit, which the VM has no control over. And then you have this second
limit the VM can set, which only has any effect if it is lower than
the hypervisor limit.
The hypervisor limit is much more like the value ksettings represents,
the media speed, which is impossible to go above, and the machine has
no control over. Reporting that limit in ksettings would seem
reasonable. But it does not appear your firmware offers that?
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2025-04-21 12:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 6:33 [PATCH v2 0/3] net: mana: Add HTB Qdisc offload support Erni Sri Satya Vennela
2025-04-21 6:33 ` [PATCH v2 1/3] net: mana: Add speed support in mana_get_link_ksettings Erni Sri Satya Vennela
2025-04-21 12:36 ` Andrew Lunn [this message]
2025-04-21 18:14 ` Erni Sri Satya Vennela
2025-04-21 6:33 ` [PATCH v2 2/3] net: mana: Add sched HTB offload support Erni Sri Satya Vennela
2025-04-22 0:03 ` Jakub Kicinski
2025-04-22 19:48 ` Erni Sri Satya Vennela
2025-04-23 0:18 ` Jakub Kicinski
2025-04-23 15:27 ` [EXTERNAL] " Haiyang Zhang
2025-04-23 21:57 ` Jakub Kicinski
2025-04-21 6:33 ` [PATCH v2 3/3] net: mana: Handle unsupported HWC commands Erni Sri Satya Vennela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c481c8a8-4e0f-4498-89f9-988673a584f6@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=ernis@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=horms@kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=kotaranov@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mhklinux@outlook.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pasha.tatashin@soleen.com \
--cc=paulros@microsoft.com \
--cc=rosenp@gmail.com \
--cc=schakrabarti@linux.microsoft.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®