From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbdCHJBu (ORCPT ); Wed, 8 Mar 2017 04:01:50 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:40691 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751230AbdCHJBs (ORCPT ); Wed, 8 Mar 2017 04:01:48 -0500 X-AuditID: cbfec7ef-f79d26d00000420c-97-58bfc87aeb1f Subject: Re: linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681: suspicious mask ? To: David Binderman , "inki.dae@samsung.com" , "jy0922.shim@samsung.com" , "sw0312.kim@samsung.com" , "kyungmin.park@samsung.com" , "airlied@linux.ie" , "kgene@kernel.org" , "krzk@kernel.org" , "javier@osg.samsung.com" , "dri-devel@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Andrzej Hajda Cc: Dan Carpenter Message-id: Date: Wed, 08 Mar 2017 10:01:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SaUhUYRSG/eauI47cRtOTacKAiGaWlXQhEYt+3B9FEoHiHx2am4qO2lyX FFFJ0tzF0RxMwSKtzEjHlcI91HJHUYtcQgxX3JckNcdr4r/n5bznvLwfH43J2wkrOjAknNeE KIMVpDFe2/6n70JMZ5P3pZ8vzrAZvV8l7PxePs5utfixQxtLJJszkY2zC4vlEnZmfABns6bm Mbavr4Jie54sUKx+aphgBz8Vkqyur1HC6rSzpIcpN5XeTXL6shSSq9ucJLiJtA4JV/U6nluZ /oFz1VljFJdZXYa4Nf05T6mPsZuKDw6M5DUX3f2MA9a67oYNSx+vrb6nEtAslYqkNDBXYWx0 hBTZAvrHPx6wMS1nShGUNu8hUawhqM7WHW/U9CdTx66aijZcFL8RTL7tRgaXGaOCz8uZhwNz ppeAnJm/mGFAMg6wW/X9MBBjnGBnY4cwsIxxB+2XzMMInLGDwjadxMCnGW+oH00nRc8p2NaO HxylaSnjC2Opt8UzDjCznoOLbAtV5YuYIReYDQrezM1QBj8wNqBvxsQGt6CosxsX2QzmOqqP mlnDoDYNF3fTEKxmdVKiyEWwt6w72r4ObR0DhJhmCjm1+ZgYIINnSXIRORirEET3Dfiw0370 phUIVuoq8WxkW3CiTsGJDgUnOhQjrAyZ8xGC2p8XXJwFpVqICPF3fhCq1qOD39W117FUj6YT 77cihkYKExnX0+gtJ5SRQrS6FQGNKcxl8LLJWy5TKaNjeE2oryYimBda0VkaV1jKGoqHvOSM vzKcD+L5MF7zfyqhpVYJyPOhTYhXDDZFPL8cVzJSaOVrH5/ytC2WPz9RGeWXefPePm5f96gr ySohT2JNxM5bf2uoVxtdc1qx2Sra0NJxr65EUYRrFevjutm/neqWp0poUUUazSfvMyWW7XRn rnOQR9evRPNUs2GPOwtb74rWPZJs7DL0vo7JRhb7uyaCgwIXApQujphGUP4Dn9V/sVkDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKIsWRmVeSWpSXmKPExsVy+t/xy7qNJ/ZHGCxrMLboPXeSyeL1v+ks Ft8PJlhc+fqezWLS/QksFm/ermGyeHHvIotF/+PXzBbnz29gtzjb9IbdYtPja6wWl3fNYbOY cX4fk8WMyS/ZHPg8HvecYfPYtKqTzWP7twesHve7jzN5bF5S7/Hx6S0Wjy39d9k9+rasYvT4 vEkugDPKzSYjNTEltUghNS85PyUzL91WKTTETddCSSEvMTfVVilC1zckSEmhLDGnFMgzMkAD Ds4B7sFK+nYJbhmfT/sXXOOs+PxpNXsD40v2LkZODgkBE4mtF9qhbDGJC/fWs3UxcnEICSxh lHj08j8rhPOMUWJa2y8WkCphgSSJR33PWUASIgIXWCW+nN/ADFG1iVHiyZQjbCBVbAKaEn83 3wSzmQV0JH59/cUKYvMK2ElMPtIHto9FQFVizuEZTCC2qECExPynq5ggagQlfky+B7aNUyBe 4tGuNUBxDqA56hJTpuRCjJSX2LzmLfMERoFZSDpmIVTNQlK1gJF5FaNIamlxbnpusZFecWJu cWleul5yfu4mRmAUbzv2c8sOxq53wYcYBTgYlXh4Pc7uixBiTSwrrsw9xCjBwawkwiuxcH+E EG9KYmVValF+fFFpTmrxIUZToBcmMkuJJucDE0xeSbyhiaG5paGRsYWFuZGRkjjv1A9XwoUE 0hNLUrNTUwtSi2D6mDg4pRoYTV4eLXgldOlr3g9ziaIZSh8L8+y+pvZwTFt+MqYgYkFg8PGw R9pzz7CW72o98in95r0vWXNuPuly+HfEZ3lU2+dzisZTfFK+lscqR5yusT5Uaz1t0rSF74Ka ps7Yyre/YdHpx0LS6686XJtlx9JzbVfeod0/7C70ujxsr//QqLWwVUPlp/zkO0osxRmJhlrM RcWJAEhUF534AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170308090143eucas1p1ed579a4c2899ab3f251d9b70e45b0a94 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170307005334epcas4p22a43a5c4e8348ec53d8b0fbc58cde358 X-RootMTR: 20170307005334epcas4p22a43a5c4e8348ec53d8b0fbc58cde358 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, Inki, Thanks for reporting. On 06.03.2017 11:05, David Binderman wrote: > Hello there, > > linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681]: (warning) Result of operator '|' is always true if one operand is non-zero. Did you intend to use '&'? > > Source code is > > if (ctx->out_type | I80_HW_TRG) { > > Also in the same file: > > [drivers/gpu/drm/exynos/exynos5433_drm_decon.c:131]: (style) Same expression on both sides of '|'. > > Source code is > > writel(TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN > | TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN, This typo was already reported by: - Ilia Mirkin, I have uploaded 2nd fixed version of the patch, apparently the 1st version has been merged [1], - Dan Carpenter, he posted also the fix[2], - and now David. I guess at the moment the best solution is to get Dan's patch. [1]: https://patchwork.kernel.org/patch/9493177/ [2]: https://patchwork.kernel.org/patch/9571375/ Regards Andrzej > > Regards > > David Binderman > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel