From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Jonathan Marek <jonathan@marek.ca>, linux-arm-msm@vger.kernel.org
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/5] arm64: dts: qcom: x1e80100-crd: add rtc offset to set rtc time
Date: Thu, 31 Oct 2024 21:09:24 +0100 [thread overview]
Message-ID: <c48f70c4-30ed-4df4-b2b3-826be77da799@oss.qualcomm.com> (raw)
In-Reply-To: <20241015004945.3676-5-jonathan@marek.ca>
On 15.10.2024 2:47 AM, Jonathan Marek wrote:
> See commit e67b45582c5e for explanation.
>
> Note: the 0xbc offset is arbitrary, it just needs to not be already in use.
>
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
> arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> index 6dfc85eda3540..eb6b735c41453 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> @@ -1224,6 +1224,17 @@ edp_bl_en: edp-bl-en-state {
> };
> };
>
> +&pmk8550_rtc {
> + nvmem-cells = <&rtc_offset>;
> + nvmem-cell-names = "offset";
> +};
> +
> +&pmk8550_sdam_2 {
> + rtc_offset: rtc-offset@bc {
> + reg = <0xbc 0x4>;
> + };
> +};
Setting random bits in SDAM is a very very very very bad idea
I'll try to get a good spot for the offset internally
Konrad
next prev parent reply other threads:[~2024-10-31 20:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 0:47 [PATCH v3 0/5] x1e80100 RTC support Jonathan Marek
2024-10-15 0:47 ` [PATCH v3 1/5] rtc: pm8xxx: implement qcom,no-alarm flag for non-HLOS owned alarm Jonathan Marek
2024-10-15 19:24 ` Bjorn Andersson
2024-10-16 6:42 ` Johan Hovold
2024-10-16 12:26 ` Alexandre Belloni
2024-10-16 12:44 ` Jonathan Marek
2024-10-16 13:02 ` Johan Hovold
2024-10-16 13:12 ` Jonathan Marek
2024-10-16 13:21 ` Johan Hovold
2024-10-15 0:47 ` [PATCH v3 2/5] dt-bindings: rtc: qcom-pm8xxx: document qcom,no-alarm flag Jonathan Marek
2024-10-15 5:33 ` Krzysztof Kozlowski
2024-10-16 6:46 ` Johan Hovold
2024-10-15 0:47 ` [PATCH v3 3/5] arm64: dts: qcom: x1e80100-pmics: enable RTC Jonathan Marek
2024-10-15 0:47 ` [PATCH v3 4/5] arm64: dts: qcom: x1e80100-crd: add rtc offset to set rtc time Jonathan Marek
2024-10-16 6:51 ` Johan Hovold
2024-10-16 13:31 ` Jonathan Marek
2024-10-18 9:44 ` Johan Hovold
2024-10-31 20:09 ` Konrad Dybcio [this message]
2024-10-15 0:47 ` [PATCH v3 5/5] arm64: dts: qcom: x1e78100-t14s: " Jonathan Marek
2025-01-12 23:35 ` [PATCH v3 0/5] x1e80100 RTC support Alexandre Belloni
2025-01-20 14:51 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c48f70c4-30ed-4df4-b2b3-826be77da799@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathan@marek.ca \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®