From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C7B4C433EF for ; Mon, 30 May 2022 07:57:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234237AbiE3H5n (ORCPT ); Mon, 30 May 2022 03:57:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234215AbiE3H5l (ORCPT ); Mon, 30 May 2022 03:57:41 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 411764EA30 for ; Mon, 30 May 2022 00:57:40 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id t13so13469070wrg.9 for ; Mon, 30 May 2022 00:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=2HKJS6RY42Dcsd1deVS4WgrJuNjTnB8t5BUZZ7XgBSs=; b=mIBfb4GlNZovTtitx6htAsOlbd6A5jiSmSjikbToJd+DS817kIltKja6Qr7QZZsfDi sWvD43up1LI9lzT2daNkUYEMQasZsZk8+qScQ6N8UutECIsZgmlqZC2hvep+zBLRCC8v pndpI9jjoIAlreFj68X+kIp+zNwA7Ko2vxL56mtHaYDDv+YQzhWgVKx67ehCN0od9SVS TFxd+jLM0Vnep2hVsJ+aBt4efLBdz2gNgIBnXJlmA4YUJZbsjHy21ewtl1gCP81TMroT Rm6fiD5gmtHTkotMnzay0MpSYgxTr2z9AI2Spo/pJklYF/XqGpq8beXW//hxqm7Mifq0 pvUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2HKJS6RY42Dcsd1deVS4WgrJuNjTnB8t5BUZZ7XgBSs=; b=hscBQeklG+fjmSBbr7myUV/vBnPDRjgWSVC3y8VQK6AWPAYgRCvV4vOw9PgtKYinzg 7moCfWiYXPs1Jb3vuaZUL0CZVINLeGSO+7rY/Gyqc+sXK5rcQeGEAxjg/umfqGPJ0PVD PiSR4cW0ZRc0yoQJ25OubuYbDcfZLVZTo6FUDeLy/dQrg56yE5WT+Pj59lZPzcTCRcWN A6qPqGK2ba81Fw7SVbNuOD5TpphHN7lv14xWQ3StOTwWK2BPkvRRCCsF9vMSoaAOqTSc zIu6bWC8tFHo1g1sbbpL4GXUE6QfNYGT1mUHM0lHSGEZxeLkWI6zOitEUQT99fah+y9M /HIg== X-Gm-Message-State: AOAM533rfMUDCBu/pIrrQahHP5pwihVMZ85lRMI1J4QyreJNYd6iKHq7 g2ZvVWNUAAKzRJPd/P/6FZK8boqFkWUbYpCY X-Google-Smtp-Source: ABdhPJxmAIoeEgWIl75mqBqxQJ09+cOXyhmjYq4ZDcJgNOMAsGbHNh/aMMUBRV0QUk+RdkKT6Vz1Ow== X-Received: by 2002:a5d:4282:0:b0:210:1351:d307 with SMTP id k2-20020a5d4282000000b002101351d307mr14111192wrq.492.1653897458728; Mon, 30 May 2022 00:57:38 -0700 (PDT) Received: from [192.168.0.179] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id h4-20020a1ccc04000000b0039747cf8354sm9339414wmb.39.2022.05.30.00.57.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 May 2022 00:57:38 -0700 (PDT) Message-ID: Date: Mon, 30 May 2022 09:57:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/3] dt-bindings: mfd: ti,j721e-system-controller: Add clock property Content-Language: en-US To: Rahul T R Cc: robh+dt@kernel.org, nm@ti.com, vigneshr@ti.com, kishon@ti.com, krzysztof.kozlowski+dt@linaro.org, lee.jones@linaro.org, rogerq@kernel.org, devicetree@vger.kernel.org, kristo@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, s-anna@ti.com References: <20220530073429.17514-1-r-ravikumar@ti.com> <20220530073429.17514-2-r-ravikumar@ti.com> <6c14aa95-00c4-960b-d71a-3967096f19cb@linaro.org> <20220530075157.43rbptnpgqqtbdho@uda0490373> From: Krzysztof Kozlowski In-Reply-To: <20220530075157.43rbptnpgqqtbdho@uda0490373> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/05/2022 09:51, Rahul T R wrote: > On 09:37-20220530, Krzysztof Kozlowski wrote: >> On 30/05/2022 09:34, Rahul T R wrote: >>> Add a pattern property for clock, also update the example with >>> a clock node >>> >>> Signed-off-by: Rahul T R >>> --- >>> .../bindings/mfd/ti,j721e-system-controller.yaml | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >>> index fa86691ebf16..290b22cab52f 100644 >>> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >>> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >>> @@ -48,6 +48,10 @@ patternProperties: >>> description: >>> This is the SERDES lane control mux. >>> >>> + "^clock@[0-9a-f]+$": >>> + type: object >>> + $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml# >>> + >> >> Thanks for the changes, but the question what is this remains. Clock >> consumers use "clocks" property. Is this a clock controller (provider) >> instead? >> >> Best regards, >> Krzysztof > > Hi Krzysztof, > > Yes, this is a clock provider node, I will add the > correct description and will also update the > example with a clock consumer node that is using > a clock from this Thanks for the description. Skip the consumer example please, just mention shortly what is this. If this is one clock, then node name is correct. If there are more clocks inside, then the node name should be "clock-controller". Best regards, Krzysztof