mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Alper Ak <alperyasinak1@gmail.com>,
	linux-media@vger.kernel.org,
	Jackson Lee <jackson.lee@chipsnmedia.com>,
	Nas Chung <nas.chung@chipsnmedia.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Hans Verkuil <hverkuil+cisco@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Nicolas Dufresne <nicolas.dufresne@collabora.com>
Subject: Re: [PATCH] media: chips-media: wave5: Fix possible ERR_PTR deference
Date: Fri, 13 Feb 2026 12:38:39 +0100	[thread overview]
Message-ID: <c4938298-41b9-43c5-bdd5-96f37536ffa6@web.de> (raw)
In-Reply-To: <20260207103224.609938-1-alperyasinak1@gmail.com>

…
> or ERR_PTR() on failure. The return value was not checked and in the

     error pointer

…
> Add proper IS_ERR() check after kthread_run(), log the error, set
> dev->irq_thread to NULL and fail the probe to prevent the driver
> from operating in a broken state.
…

See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.19#n34


Would a summary phrase like “Prevent error pointer dereference in wave5_vpu_probe()”
be more appropriate?

Regards,
Markus

  parent reply	other threads:[~2026-02-13 11:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-07 10:32 Alper Ak
2026-02-11  9:12 ` Nas Chung
     [not found]   ` <CAGpma=5ONpUwnOStE+cLpJcqrb-=ZYT4krx=whgeAup1ACERQg@mail.gmail.com>
2026-02-13  5:38     ` Nas Chung
2026-02-13 11:38 ` Markus Elfring [this message]
2026-03-06  6:32   ` Alper Ak
2026-03-06  6:54     ` Markus Elfring
2026-03-06 13:50     ` [PATCH] " Nicolas Dufresne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4938298-41b9-43c5-bdd5-96f37536ffa6@web.de \
    --to=markus.elfring@web.de \
    --cc=alperyasinak1@gmail.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=jackson.lee@chipsnmedia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nas.chung@chipsnmedia.com \
    --cc=nicolas.dufresne@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®