From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67099ECAAD2 for ; Fri, 26 Aug 2022 09:03:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245575AbiHZJDr (ORCPT ); Fri, 26 Aug 2022 05:03:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229904AbiHZJDp (ORCPT ); Fri, 26 Aug 2022 05:03:45 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F195CD39B9 for ; Fri, 26 Aug 2022 02:03:43 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id q7so1180796lfu.5 for ; Fri, 26 Aug 2022 02:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=6wjKp5duJTgVfzr1UXrwjF1SALPZrTw3gPVi12ZjH/g=; b=qzAMa2OWyy36WWaZwRfSzNNZqXwBIqn7RW1geIbwXoLZbxJ20jcuOQ43Pd0nkn9fOb RCX57WrBDnQ1/MtpmUvixjAeiITsndFGd8381UD2uc3E6UxNP3vSDTBAYHb9EL9STfjL bQM576O9O5ND/BnhZhbDaGupllZa2HTbhftLmuVrfydgxE2jGwtgn8usWEKJ0lYMa62L p7/uf3nFQIr5eKPGwd7y30DFVGzuy+sscnKJj+SIw9j8vfs5ozq/P+aGco/UTxF+cZFr mIw65hXoJ151Vp4g47rISWYFjKN3M0eJZgDW8k1Prs2N903GaB8QMDwiDlsZGR+XB4x8 32wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=6wjKp5duJTgVfzr1UXrwjF1SALPZrTw3gPVi12ZjH/g=; b=jEnfTiFb9SZLyldDSAzpgJ0jfW/g9FAD7lExtUoelQHwbRi/GBKqaI3tQgQ7bWU4Ae 3e+/8a4qMDWvcr7jW4UryeI4VA5aWFXkufgXW8ao5ZNR0/pNK0yfwKWYOlsPRQYfaegk xc1IvSV+Ev/nylaYKzRfxv6FHR9rHRReWWJuE8CGLo1bRs1OPN5ZsFbHVWAGFRIqhFhL qD6c9KECsYP2tFTCXvB+QSyGpFdNsLTo+nfCtBt/wBudo7QkOkduAtRjd2QmI42lQLLa TRql66xTpRtC+3bdJTwGJDx5ldFDdv4JOw6w+tOYY73aHTUJ9QGQrndodexq0NXHXIsW SjNw== X-Gm-Message-State: ACgBeo3uWTOkQDPq+2IvmgWJOE5dxe/Qeqt6VLpkVMRCvcfVR95OY22j FGKPhF2MeFGqO+ZtZeUrNZshWQ== X-Google-Smtp-Source: AA6agR4CyEq8JY4VnBVKnVhOwimuVLC9QM98RVtC/yFTvCc2rvMTc7BcK1xzXFH+y17DGL5I65x8Kw== X-Received: by 2002:a05:6512:1087:b0:492:e36c:d6c6 with SMTP id j7-20020a056512108700b00492e36cd6c6mr2094268lfg.502.1661504622340; Fri, 26 Aug 2022 02:03:42 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id o4-20020ac24e84000000b00492de54940asm318699lfr.82.2022.08.26.02.03.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Aug 2022 02:03:41 -0700 (PDT) Message-ID: Date: Fri, 26 Aug 2022 12:03:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH v2 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl Content-Language: en-GB To: Stephen Boyd , Rob Clark , Abhinav Kumar Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, Sean Paul , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Kuogee Hsieh References: <20220623002540.871994-1-swboyd@chromium.org> <20220623002540.871994-3-swboyd@chromium.org> From: Dmitry Baryshkov In-Reply-To: <20220623002540.871994-3-swboyd@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/06/2022 03:25, Stephen Boyd wrote: > This struct member is stored to in the function that calls the function > which uses it. That's possible with a function argument instead of > storing to a struct member. Pass the pixel_rate as an argument instead > to simplify the code. Note that dp_ctrl_link_maintenance() was storing > the pixel_rate but never using it so we just remove the assignment from > there. > > Cc: Kuogee Hsieh > Signed-off-by: Stephen Boyd Reviewed-by: Dmitry Baryshkov > --- > > dp_ctrl_on_link() almost doesn't even use the pixel_clk either. It just > prints the value. I kept it around because maybe it is useful? But if > not, then we can remove even more code. Feel free to submit a patch and check if anybody (Kuogee? Abhinav?) complains. -- With best wishes Dmitry