From: Val Packett <val@packett.cool>
To: Griffin Kroah-Hartman <griffin.kroah@fairphone.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Luca Weiss <luca.weiss@fairphone.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 0/3] AW8695 haptic driver.
Date: Tue, 15 Sep 2026 01:14:27 -0300 [thread overview]
Message-ID: <c49fe267-7da4-4b34-8dbd-3536a327423c@packett.cool> (raw)
In-Reply-To: <20260914-aw8695_haptic_fp4_driver-v1-0-156f7549149a@fairphone.com>
On 9/14/26 11:37 AM, Griffin Kroah-Hartman wrote:
> Clean-up of the aw8695 haptic driver patchset that was sent in 2022.
> Variables dependant on devicetree have been hardcoded, and unnecessary
> functions have been removed.
> [..]
This looks similar to aw86927.c just with a somewhat different register
layout, but there's even the same waveform and so on.
Could it be better / worth it to do everything in one driver (aw86927.c)
and only have different register accessors per model but shared "logic"
overall? Or would that make testing too annoying?
FWIW I've been trying to bring up aw86224 which has even fewer (but
still *some*) differences to aw86927, so I'm potentially interested in
having a unified base to add it to (when I figure out why it's stuck in
overvoltage protection or whatever it was..)
Thanks,
~val
next prev parent reply other threads:[~2026-09-15 4:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 14:37 Griffin Kroah-Hartman
2026-09-14 14:37 ` [PATCH 1/3] dt-bindings: input: Add compatibility for Awinic AW8695 Griffin Kroah-Hartman
2026-09-17 8:38 ` Krzysztof Kozlowski
2026-09-14 14:37 ` [PATCH 2/3] Input - aw8695: Add driver for AW8695 haptics Griffin Kroah-Hartman
2026-09-17 8:43 ` Krzysztof Kozlowski
2026-09-14 14:37 ` [PATCH 3/3] arm64: dts: qcom: sm7225-fairphone-fp4: Add " Griffin Kroah-Hartman
2026-09-15 10:04 ` Abel Vesa
2026-09-17 9:25 ` Konrad Dybcio
2026-09-15 4:14 ` Val Packett [this message]
2026-09-24 9:01 ` [PATCH 0/3] AW8695 haptic driver Griffin Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c49fe267-7da4-4b34-8dbd-3536a327423c@packett.cool \
--to=val@packett.cool \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=griffin.kroah@fairphone.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®