From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5679528B516 for ; Thu, 17 Jul 2025 10:59:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752749978; cv=none; b=DeAkA3ugB/WCG6/ay4kKwh4LI3I8cUjCkcPz1RBR3ZAMfIwdbttQ06q19MKyJNuKGgiMiR+tJ5ow4vyLqHC+1slZLV9te5rm58fp+3T42+TjsTP2twguqi5azs/IzBZQk28DNK0jj1OT5YDRORktf7aaohcOYdwW363ozfUMuH0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752749978; c=relaxed/simple; bh=dFFgXr0V7KJsMFT9bzLI4LKgPjgSk0pPsZwF+/Ain5Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XlF2w0GjQBsEFcK3om9jPfgjZQPmnVgx+aAzV+snQLR00liN96MXbiXqZxBJ1eikvWHYEQBkDGl9SL9PWwGe4bG/JQaZkdB0bvOiUR6HnAAUVBSAjCKnc07GD/ru1WKxZ/Cmg4T7ivKL+yXrPdTCzW6hYhvCXb6iVGMD+bozmoo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lcCN/7ii; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lcCN/7ii" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56H57Djm015613 for ; Thu, 17 Jul 2025 10:59:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9m1vcYVumY1HNbRTAgr3tsYxKmOeN38kHcJutqp6GcY=; b=lcCN/7ii+6ET6bQm W5JrOXTbbJCbkNfiX90VFzbFNdnsU89a6yKqCm+gzmQQAopy7HKsInmt/7b0KfCW CrMJ+zifO1sCVrSDy2XozNYjbi2J1RrZD/ID8aWW3uY+Yd/mej6t901aSHQC/j0F UQVMGzHYRRhRkB50lYLjBjKGsdM3r2zolpzCtpWu2vIKhMRg3ygMb6tMGgPLnPUT Kddr/9vO2X9atuwi3AJDBKWHI1nTjf9QNJKiwKSu7jUyfAZ/t/DKBmj+D0D5TFeS QkXd6PAw4KKQ0oK/6itX5Et1huo/K4b0ul9qLoOi47OgldpKY93VtU5mbagw3LDY OUQgOg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47w5dyt9m0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 17 Jul 2025 10:59:35 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-747ddba7c90so810554b3a.0 for ; Thu, 17 Jul 2025 03:59:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752749974; x=1753354774; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9m1vcYVumY1HNbRTAgr3tsYxKmOeN38kHcJutqp6GcY=; b=WIg8cCX3MYQQ8F/BJ+6B0yXNu3yQGMd4e4FzhlRcLkbNl7T4n906NaIYFf1lW6OEth aLGejawD18dUhPySNX2is5bwjelWpLu8QJc4jALYMOd6ZcjecWkzFKaRCYdHJIGCDFZX I7TGUANKQbKvBdoOHkKlu9f+YW4DIwE+EVvYh2skRyFWL9RcW7TWCWimBDeNly3x8Rlf UjHNrwlm7PDdUYdSdpbHcRI7lvjiQtdPmeCn082BWP/K6LigdHUfGrwmZTKmtFNcM8YO 9QY9fpFpf0AJmsAxCqTtdn1FaSDVwn5RohGiQmGXwgb0G92tDkr6ygLPZDmoeFa6Z2vs iN2Q== X-Forwarded-Encrypted: i=1; AJvYcCW4FizehtbFoTKgbCYDsZaabN01fgDR2/eoISakpd46tdPTlm2mq5YFNomkAHyTeT2oupCOSqsYmA2ar6w=@vger.kernel.org X-Gm-Message-State: AOJu0YyT8Ys5ZbyG82FMYl4M3JJihuc1hvNNWlcE6Sjdv6/01gHs9cXg abA4vuuy2sf68ahls+lmIhbDWiwSUMW5ABsR+b8FwYVzjxZiAStM0P5gGFhxCGGLYD+brKGWqqJ EfsjLQZTqpdNNT91hX3HLcwVNkaLeFp/6+AjO9Elo9mPo2og9st/q8ovdSKzQHdOCu9M= X-Gm-Gg: ASbGncvVlz8M573I0AUw1RvIdjz/8RfupwrQHCw2trDsSU/SVPdt/Qcbd0B58Wz0WlZ cRHoaNY9q4GyH6UIdnlQtlLMHovNZaqQWfhMDCd4AumrWXKFIFkz51I+JaBkDQHNxzr/9YFkhXc mLqjr55FhATLFSC8zViLkIHR5tzBBfq9fZNWgr2DdgyiphHxf9JR9j9e+d1LgZRZM2aUr4FWlRc I+rt8rjMQ2Lv4pq1Flo9KICjjFYJqnFaISdHMrI7+rOYGOopporWEaI3p7Erbr5whA4GTvopKoj LdwpzA5clpI1A7Eat70C8PYTSZ+dGG31NEer+GpGpw1Jrxnif0I+kz+HdWBoP35+sNue9qvKgFR BHjJyYkahWW5Dij7HQ14gCVyt3DuVqkPH X-Received: by 2002:a05:6a00:1945:b0:748:ed51:1300 with SMTP id d2e1a72fcca58-75722869e2dmr8491718b3a.9.1752749974365; Thu, 17 Jul 2025 03:59:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHS/1Q6FwFVvJNpwEqbklIvf1jeMXGBNVBGHmlE5Rp/k57dq0BzAzgcVPz3GfhsuMeAZ0ucYA== X-Received: by 2002:a05:6a00:1945:b0:748:ed51:1300 with SMTP id d2e1a72fcca58-75722869e2dmr8491687b3a.9.1752749973872; Thu, 17 Jul 2025 03:59:33 -0700 (PDT) Received: from [10.133.33.245] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-75914e6f81asm309433b3a.152.2025.07.17.03.59.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 03:59:33 -0700 (PDT) Message-ID: Date: Thu, 17 Jul 2025 18:59:28 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] wifi: ath12k: Use pci_{enable/disable}_link_state() APIs to enable/disable ASPM states To: Konrad Dybcio , Manivannan Sadhasivam Cc: manivannan.sadhasivam@oss.qualcomm.com, Jeff Johnson , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Nirmal Patel , Jonathan Derrick , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath12k@lists.infradead.org, ath11k@lists.infradead.org, ath10k@lists.infradead.org, Bjorn Helgaas , ilpo.jarvinen@linux.intel.com, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, Krishna Chaitanya Chundru , Qiang Yu References: <20250716-ath-aspm-fix-v1-0-dd3e62c1b692@oss.qualcomm.com> <20250716-ath-aspm-fix-v1-4-dd3e62c1b692@oss.qualcomm.com> <38ace6a3-d594-4438-a193-cf730a7b87d6@oss.qualcomm.com> <03806d02-1cfc-4db2-8b63-c1e51f5456e2@oss.qualcomm.com> <5502b2eb-f6d1-4ece-b918-1c8561a92607@oss.qualcomm.com> Content-Language: en-US From: Baochen Qiang In-Reply-To: <5502b2eb-f6d1-4ece-b918-1c8561a92607@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: q7TruPrMY0ZYTrBTryISIoTlZKxWbBEp X-Authority-Analysis: v=2.4 cv=RtXFLDmK c=1 sm=1 tr=0 ts=6878d797 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=VwQbUJbxAAAA:8 a=Ghoe0wLkBCzmZIYDIaAA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE3MDA5NiBTYWx0ZWRfXy1j4VwpRgMbZ 8W8Sd9LC71CDP1iJ3Es93NMUP2ZpCRnPrifWNmuPL6jImhocZoN1r27k5Skf1CBV43mOAXsVFVd rgLHVuPhN1jxoQXBakgvRIdgGZw6Vnk7R+vSdmbvIukIUjxH66yuTrqTO9SK84RnRxfA2tZir3H LZhanyqN8t0lJFxyu0dPiak9aNdwHrSf2XNuSYeiiQPO+bhf1zydT0777ZapFyv8NMwYPqIQ+jJ X143NuJpT41mwub1AiGK9IM3fTvX3Ke/l+j1jjGoxpDJdosOkXJCv9zINRX2U5fSS4PaRMk5m2K QQTc2T5OLOqn6e4zPmsVp33sJUAAoY7l6mABLN7gt4cm/476JvVcoMOwsRfEIOVsLje6/15pJgW symZejTCi2jR45poqF0+QfsFOGQJmWZDpy2fj1QxuMJdk8pLRr7Jd9tDg4MNbIN3QRpWNFGr X-Proofpoint-GUID: q7TruPrMY0ZYTrBTryISIoTlZKxWbBEp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-17_01,2025-07-16_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 clxscore=1015 mlxlogscore=999 priorityscore=1501 phishscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507170096 On 7/17/2025 6:55 PM, Konrad Dybcio wrote: > On 7/17/25 12:46 PM, Baochen Qiang wrote: >> >> >> On 7/17/2025 6:31 PM, Manivannan Sadhasivam wrote: >>> On Thu, Jul 17, 2025 at 05:24:13PM GMT, Baochen Qiang wrote: >>> > > [...] > >>>> In addition, frequently I can see below AER warnings: >>>> >>>> [ 280.383143] aer_ratelimit: 30 callbacks suppressed >>>> [ 280.383151] pcieport 0000:00:1c.0: AER: Correctable error message received from >>>> 0000:00:1c.0 >>>> [ 280.383177] pcieport 0000:00:1c.0: PCIe Bus Error: severity=Correctable, type=Data Link >>>> Layer, (Transmitter ID) >>>> [ 280.383184] pcieport 0000:00:1c.0: device [8086:7ab8] error status/mask=00001000/00002000 >>>> [ 280.383193] pcieport 0000:00:1c.0: [12] Timeout >>>> >>> >>> I don't see any AER errors either. >> >> My WLAN chip is attached via a PCIe-to-M.2 adapter, maybe some hardware issue? However I >> never saw them until your changes applied. > > It'd be useful to know whether that's a Qualcomm platform running > an upstream-ish kernel, or some other host - we've had platform- > specific issues in the past and the necessary margining/tuning presets > were only introduced recently It is an Intel based desktop, so not a Qualcomm platform. But it is indeed an upstream kernel: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git > > Konrad