From: Guenter Roeck <linux@roeck-us.net>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH v1 1/1] hwmon: (qnap-mcu) Remove (explicitly) unused header
Date: Mon, 31 Mar 2025 06:53:53 -0700 [thread overview]
Message-ID: <c4b467ec-471f-4cf8-9666-17db6284d26b@roeck-us.net> (raw)
In-Reply-To: <20250331070600.3985850-1-andriy.shevchenko@linux.intel.com>
On Mon, Mar 31, 2025 at 10:06:00AM +0300, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
>
> Note, that fwnode API for drivers is provided in property.h
> which is included here.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/qnap-mcu-hwmon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hwmon/qnap-mcu-hwmon.c b/drivers/hwmon/qnap-mcu-hwmon.c
> index 29057514739c..e86e64c4d391 100644
> --- a/drivers/hwmon/qnap-mcu-hwmon.c
> +++ b/drivers/hwmon/qnap-mcu-hwmon.c
> @@ -6,7 +6,6 @@
> * Copyright (C) 2024 Heiko Stuebner <heiko@sntech.de>
> */
>
> -#include <linux/fwnode.h>
> #include <linux/hwmon.h>
> #include <linux/mfd/qnap-mcu.h>
> #include <linux/module.h>
prev parent reply other threads:[~2025-03-31 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 7:06 Andy Shevchenko
2025-03-31 13:53 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4b467ec-471f-4cf8-9666-17db6284d26b@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=heiko@sntech.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®