From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751051AbdALQby (ORCPT ); Thu, 12 Jan 2017 11:31:54 -0500 Received: from mout.web.de ([212.227.17.11]:63532 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbdALQbw (ORCPT ); Thu, 12 Jan 2017 11:31:52 -0500 Subject: [PATCH 1/5] pinctrl: mvebu: Use kmalloc_array() in mvebu_pinctrl_dt_node_to_map() To: linux-gpio@vger.kernel.org, Laxman Dewangan , Linus Walleij , Sebastian Hesselbarth , Thomas Petazzoni References: <12880bc6-1695-074a-788b-dd936f6f795a@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Thu, 12 Jan 2017 17:31:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <12880bc6-1695-074a-788b-dd936f6f795a@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:iHQMoUkNxcqpj9sqh0b/vbTGsSQGWg0v0RMxRjNP8t3kl/JXqTI NHtwhfCtag40misCnD6fwLOLGCmQAsgxZMKj91YZoZI40sIwjiZjTmK4UcMiOmeSPW5ueCI njjqySE/37XbDLo9OMLhTTAgudmyKOBhpZPY/DsgATqhfVEwZsn9O3l+re22NkeSTpkpIDq lzsM6qlzYBD4MWvyZYi8Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:ILnolUd1PUo=:5Xxxcqno4kdlOsXpx3a4OD +lGTVrlC/Z2L+CcXyz1YFfax73IKCjvzTGQwsr3PWONiBKOTo9lzSXRmhfhHZ33VCh1icVMnM g7ET9PRxBQtp/u6EoNmkZI02Zp3xsyzmh8/m23qXEZwmhXLNZnSiHcmyVsHHyc7U+ebyJSzOd rLIbDg2vSFMtTvs66FX0B7fsjwmEQ7YBeEbUtfeGLLJROwGSShjOhxa1Z39Dj6RjFMRhljxNb Q5GdHdyKe3GO+ZMw0XSPcQ99IOYcmrOCGsbZUa1SDJnptPYrjqbnv3BIyVGeIqzlrmd/eO4Bn Gz37NONnSKArTlQoMBmLEqZWGZ2V5EHxIC7FNqAqi/yf7CWJ7shuhBO3n/9Yyq+LTmzqtu1st J0IXog1k8yXHGykbzvcXVGAN/9siKH8SXZ/WCSZHl3Hnw88DKpFRvRRl8GHqhfsN4LWlat9Gi 1brQm1WU6EiuDySpCe8PCZNVcywntAi7I0fIScNxyx+QF9khpO9j8cJDMwFBjPmNHNP1CISNr kB61iSloTbemvSM4jCh8Me74Ycd7Axo/AcFYfPjSCOl8bSsdjfEXghYbMdCwaAkk9qwUqUW+7 /nn5Ph6QvyWGrX8Pr/Kvop7j0ujhianE+BDXkCijlEFK3Jng5hioI3gl6luWWfyKOuSwezTnr Uqasm3AZbV8CBNma7Swnw3yDUlGdNBKj7yaoZhPDdxPOgZxmVh89WbvuNdufNWdEVo5SG+Ivg jD/LW7EtVfvrX0IS/BV2WlePW+SmR5drgfpOaUDNYvtSfhh100VffgoKm2UISgk+p0fwBv8Nw a54ZvjT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 12 Jan 2017 16:00:15 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/pinctrl/mvebu/pinctrl-mvebu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-mvebu.c b/drivers/pinctrl/mvebu/pinctrl-mvebu.c index b6ec6db78351..c2f74572ac01 100644 --- a/drivers/pinctrl/mvebu/pinctrl-mvebu.c +++ b/drivers/pinctrl/mvebu/pinctrl-mvebu.c @@ -398,7 +398,7 @@ static int mvebu_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev, return 0; } - *map = kmalloc(nmaps * sizeof(struct pinctrl_map), GFP_KERNEL); + *map = kmalloc_array(nmaps, sizeof(**map), GFP_KERNEL); if (*map == NULL) { dev_err(pctl->dev, "cannot allocate pinctrl_map memory for %s\n", -- 2.11.0