From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBFD0268696 for ; Tue, 3 Jun 2025 06:59:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748933961; cv=none; b=nTgjtdFDWnRIuOygShCXCelNMU9RkTXNKVWezqOhnarcYNi3gPcRvzSAEXJYYlPza8JOE/YCZL59KI6cmSeeBGCwoWjZ+KVoXJLMC4XGja2MBg/CglB3HmlNTpILqOM4YzMdTBWf7reRRxa1Tp6h0uyrGejKU1bISUr7PG+WEkM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748933961; c=relaxed/simple; bh=yIl91cIODbcq6rOSVNz4VGeqdOw6XOvYiMSRWZsk0uY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WMOvKrAbjMrtwzAhf35eWwO9wFRjEsEJZHrfOQz/iJQrUb6dnEQw+VFlnrOr6w94g/ehnblirgoCaQiM4t53nOdgvUeUYh+W+oPAvtzibhUAI65634/k0pwdFVidQUzMDryCBuhd6oUssJ9Mw6YJMbmGLEqpcy0//oj7Ok3ZQ0E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=G1b6teRp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="G1b6teRp" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5536eSQn009145 for ; Tue, 3 Jun 2025 06:59:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= O88Sfa6gWtkGp5uiGxYhsgS/QzkSjFVA7I558x1JjIE=; b=G1b6teRpu84OEJhK W/VaIX6157DxmGKESVyCRWKNHxBN2l/F1tUpMIteOjmR4oLIH7nNjiwew6psKOzN bBcFcUDulVJbXpNzCw4A5YVPrArTD/ddqE6aDLl08PXG8gK0yyUzptN7CFGwtzeO foWkmS8EPPejJ0p0bHmYImfCj1OaZ4skpZ+LLlq32fGZhOFftHBgRM2/rINFMk0q I1Fm1EF0SZ3FOMx9eRU5aT1zpYNGMNCLLGLER2K5OyQS7EfybDqSdLyegWraSWfW DKsZ1QuydLSMQQCFdqJ/iFKOHWf6niZCLP1Qj6AWPq0w+EeCHSSYLqzTGZITo0LK GQnFHQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 471g8t9nx1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 03 Jun 2025 06:59:17 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-311d670ad35so4921179a91.3 for ; Mon, 02 Jun 2025 23:59:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748933956; x=1749538756; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O88Sfa6gWtkGp5uiGxYhsgS/QzkSjFVA7I558x1JjIE=; b=tUNPpjXzEA9LBPnofvNjs/Tj2HCR/hqYCr2H5NhGFkYhX0iO3IYQNYrxzwywihV9p/ 3zh7WLJAz0U0gZnuAo+Y4D6kblJ+O5+W65Xpk5TzQk3+zhD3i9VtieOq4z1VeoN/aMa5 pFdXvLlmtXDnpKHRff4x13NNrnhxJziY9X6h2DMZNgSYXWLi8/uAkYjPSOgqsueGSsi2 UDRxWgbJ0Zsb1uElMwfnZO84793g5AaABory3xuMBNWzCZmjgORPaibMEp4RaiXTH9v7 FzYXtJeqifK/maiY1EL8S2N8kJSpt9iuSMPbXxo5LfQ81odbdAy+ZU+Yr+Cq8YVUE6Ih lAdw== X-Forwarded-Encrypted: i=1; AJvYcCWURGjXCCH7wDy9JajHE5yBDVIw54s8Bl1cIxi6D7tPLWyUaiKlpx1a4VkrrjqTBD3/2cMcELvYkoBp+ys=@vger.kernel.org X-Gm-Message-State: AOJu0YwwUrzZrEhyBYIfAlzA2Gp3wJXjjuhBhzwQvRJuph/THf5/7Pkr 5Zf4PvT3oBICdREN56ikxOjP63yk3rhtcNilaB2xfH89+pAaHR8GB/1w8WZKnp4tKIZuHQk0GrQ gLrudkQIFK/9MMhpoJCR2JzW+5WoGnr/Txa3sefHK+H0jvQs86LEh0Y3qSP2FsADBq9g= X-Gm-Gg: ASbGncvmcozwT23mbNFBAZKrBuXdVS/R/iwDPNYQiQyH7oEIYvIcGYji63luWV+PRbf hLLcgh8Dm29XbYR+F5wIAUDFoXOJOt0mfyLMKRJ3e3DW6dpdTJu4Uz6gz0wh9phvu2Y69V1y/Bh MMkxzxeXelBxywERX1iz0bqBDJtEuMnEhSTHbx3l3u1ulaZJK9MNrbtpIADZYSq9XmNb8SM37l6 xKr3KcsJ+D2ntPuxhWVsK/pRjXFU/SkHhN8iKRrrTzldTcj9luWYYOjWk6NbzkzGrW1KPKBtp4G Y5ms7oN/ZdOq6gXJyxkEbRq2nyzDUl5BzyzTL/wTmfI8NfDt09tw8aKE1auOdIjqJvlgskRrNS7 P X-Received: by 2002:a17:90b:1dd1:b0:312:1147:7b16 with SMTP id 98e67ed59e1d1-3127c75a1f6mr16567639a91.35.1748933956182; Mon, 02 Jun 2025 23:59:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/449gaCP9UeICVPOMl7ImevR8RyxYzaDJddV9j5cUxAmjFJ/jq43ySQCuFyd+RVw0vYtQrg== X-Received: by 2002:a17:90b:1dd1:b0:312:1147:7b16 with SMTP id 98e67ed59e1d1-3127c75a1f6mr16567596a91.35.1748933955725; Mon, 02 Jun 2025 23:59:15 -0700 (PDT) Received: from [10.133.33.127] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3124e2e5e77sm6640325a91.20.2025.06.02.23.59.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jun 2025 23:59:15 -0700 (PDT) Message-ID: Date: Tue, 3 Jun 2025 14:59:11 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/8] dt-bindings: soc: qcom: pmic-glink: Move X1E80100 out of fallbacks To: Krzysztof Kozlowski , Sebastian Reichel , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman Cc: Subbaraman Narayanamurthy , David Collins , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org References: <20250530-qcom_battmgr_update-v2-0-9e377193a656@oss.qualcomm.com> <20250530-qcom_battmgr_update-v2-6-9e377193a656@oss.qualcomm.com> <4e093835-af3b-4a84-b42f-fa7d3a6f60a1@kernel.org> <14cba9ae-e3bb-46e8-a800-be5d979b2e06@oss.qualcomm.com> Content-Language: en-US From: Fenglin Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjAzMDA1OSBTYWx0ZWRfX1qEydET6UrhW 62FBoEGC93UK7bFERWVKF9jg3briyF9KhDnvv9UG2Jt40TAovpRxWzFxgDoqw5tmVO3201haykm Nupwzs1VhAafpODY0REH0fyd5Yaa4BvtSWgw1uUrvJaIL/LATuW/x7c0uKKUCHYu80/JQeFqQ1J hQMyes5oomN0y6oX/1P8J9/HgMQAFKzmsNJ4I4JpOZPmaj+Afbmt0hRxKXqTp5lQNDO0MmQwB9R iU11CTMBPgQONQFcU1h/vbKKkFP64MviOM10nO6RR9vER4d4V/IzWD5gqeIu3y+cTNqSMCFsrTL BRB1xyLr9j8IgSdEScc+FbckazIAQuqGuLwF0YnCenKmCcru0RC6XgTNg7vyMcNk4pT3HFBVTUS xvA6Cwpzp8AYCoslwcbljSRtrm6VDdKi+5SwU6IcFxf74bk2z/FPomTB3UKuY4ZI+DMHkk6I X-Proofpoint-ORIG-GUID: zT9ioWOKyA2CNSbtTGLlx7a27fIhcnW_ X-Authority-Analysis: v=2.4 cv=OuxPyz/t c=1 sm=1 tr=0 ts=683e9d45 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=EUspDBNiAAAA:8 a=dyB-bXEIEhcmCqCGgV4A:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: zT9ioWOKyA2CNSbtTGLlx7a27fIhcnW_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-03_01,2025-06-02_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 malwarescore=0 impostorscore=0 mlxlogscore=895 lowpriorityscore=0 spamscore=0 mlxscore=0 suspectscore=0 priorityscore=1501 adultscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506030059 On 6/3/2025 2:47 PM, Krzysztof Kozlowski wrote: > On 03/06/2025 08:42, Fenglin Wu wrote: >> On 6/2/2025 3:40 PM, Krzysztof Kozlowski wrote: >>> On 30/05/2025 09:35, Fenglin Wu via B4 Relay wrote: >>>> From: Fenglin Wu >>>> >>>> Move X1E80100 out of the fallbacks of SM8550 in pmic-glink support. >>> Why? >>> >>> Do not describe what you do here, it's obvious. We see it from the diff. >>> >>> >>> Best regards, >>> Krzysztof >> Previously, in qcom_battmgr driver, x1e80100 was specified with a match >> data the same as sc8280xp, also sm8550 was treated a fallback of sm8350 >> without the need of a match data. >> >> In ucsi_glink driver, sm8550 had a match data and x1e80100 was treated >> as a fallback of sm8550. There was no issues to make x1e80100 as a >> fallback of sm8550 from both qcom_battmgr and ucsi_glink driver perspective. >> >> In patch [5/8] in this series, in qcom_battmgr driver, it added charge >> control functionality for sm8550 and x1e80100 differently hence >> different match data was specified for them, and it makes x1e80100 ad >> sm8550 incompatible and they need to be treated differently. > So you break ABI and that's your problem to fix. You cannot make devices > incompatible without good justification. I would say x1e80100 and sm8550 are different and incompatible from a battery management firmware support perspective. The x1e80100 follows the sc8280xp as a compute platform, whereas the sm8550 follows the sm8350 as a mobile platform. The difference between them was initially ignored because the sm8550 could use everything that the sm8350 has, and no match data needed to be specified for it. However, now the sm8550 has new features that the sm8350 doesn't have, requiring us to treat it differently, thus the incompatibility was acknowledged. > > Best regards, > Krzysztof