From: Dan Carpenter <dan.carpenter@linaro.org>
To: Su Hui <suhui@nfschina.com>
Cc: hubcap@omnibond.com, martin@omnibond.com,
xiyuyang19@fudan.edu.cn, cymi20@fudan.edu.cn,
tanxin.ctf@gmail.com, devel@lists.orangefs.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] orangefs: Fix possible NULL deference in orangefs_mount
Date: Fri, 23 Feb 2024 09:22:53 +0300 [thread overview]
Message-ID: <c4bf77fb-c289-4f5d-9f20-e0861a543d91@moroto.mountain> (raw)
In-Reply-To: <dc2d05ab-2a56-bf9d-8500-858466ab68e6@nfschina.com>
On Fri, Feb 23, 2024 at 10:11:03AM +0800, Su Hui wrote:
> On 2024/2/22 18:45, Dan Carpenter wrote:
>
> > This was already fixed in commit:
> > 9bf93dcfc453 ("Julia Lawall reported this null pointer dereference, this
> > should fix it.")
> >
> > Amusing subject... :P
>
> Oh, really sorry for this. I forgot to check the linux-next git.
>
> I'm not sure if commit 9bf93dcfc453 will lead to sb refcount leak which was
> previously fixed
> by ac2c63757f4f ("orangefs: Fix sb refcount leak when allocate sb info
> failed.").
>
Yeah, you're right. Do you want to re-fix that?
regards,
dan carpenter
prev parent reply other threads:[~2024-02-23 6:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 10:25 Su Hui
2024-02-22 10:45 ` Dan Carpenter
2024-02-23 2:11 ` Su Hui
2024-02-23 6:22 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4bf77fb-c289-4f5d-9f20-e0861a543d91@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=cymi20@fudan.edu.cn \
--cc=devel@lists.orangefs.org \
--cc=hubcap@omnibond.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@omnibond.com \
--cc=suhui@nfschina.com \
--cc=tanxin.ctf@gmail.com \
--cc=xiyuyang19@fudan.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®