From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CD8B2E1753 for ; Thu, 28 Aug 2025 08:29:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756369761; cv=none; b=bu7CGM+G6O6IXJGsDmCtCfXZWV120sKnmwWda/TkrVi484a2GIqoaAOZhnB6EWYXC13eI9ybssqP4O37jAXq4zDNEbYi15peM73Yfj+QqZfKjw85EXDa+RnjO5gLzlSurrmBgZW38dPsGlApiLB9enUSVo5zDdDazypGWeutdU4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756369761; c=relaxed/simple; bh=yzMh3PP7RAVftfshowsLFWms1axqem9GSPNMwI0stto=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sFV2MoWoYU+9+XydXa1pHTeWoh9dB87NFBOXk69V1WoPGBmbrtn29LBDUl0Tc6fO0EWq8w/Fweu9vq1PEtflYqFgugDwHU4n5IyajA7y6OcGHgGFzm2pq66lPhtx6xvJdrwAfBG7fs740xAE/OcFmh/EVn9cQ4c5mmxTKHeq/Nw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=PN5Vx5zw; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=4d0JWSqz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=PN5Vx5zw; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=4d0JWSqz; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="PN5Vx5zw"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="4d0JWSqz"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="PN5Vx5zw"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="4d0JWSqz" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 93D7A21BED; Thu, 28 Aug 2025 08:29:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1756369749; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NGb0INo96XhZw29z1q8c4k1DaV5Urg02jxB94QTW9Y4=; b=PN5Vx5zwF8VrgcJNanxRyKj9mbxl2bABCjqmTyuJ7TNq5oDQ7YZ9wgXPKErurWW2Sjk2JX Z6ZrWHfCG1T+udOHBH++XfOgWWRPrt59H6HFaxL7SbxR1yrXgWHY6ZZIeACMqDjl0Tk1xz pfsCJ0CEEoZ3gVDo1hqJ4OorOPGRICo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1756369749; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NGb0INo96XhZw29z1q8c4k1DaV5Urg02jxB94QTW9Y4=; b=4d0JWSqzactyYouq5XT93hKkLA3+ECR2fybXcRDNR8pRxcbKQxRSgGtZWoJPCOcZAvrQkb XAMYBejRShB13sCg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=PN5Vx5zw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4d0JWSqz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1756369749; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NGb0INo96XhZw29z1q8c4k1DaV5Urg02jxB94QTW9Y4=; b=PN5Vx5zwF8VrgcJNanxRyKj9mbxl2bABCjqmTyuJ7TNq5oDQ7YZ9wgXPKErurWW2Sjk2JX Z6ZrWHfCG1T+udOHBH++XfOgWWRPrt59H6HFaxL7SbxR1yrXgWHY6ZZIeACMqDjl0Tk1xz pfsCJ0CEEoZ3gVDo1hqJ4OorOPGRICo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1756369749; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NGb0INo96XhZw29z1q8c4k1DaV5Urg02jxB94QTW9Y4=; b=4d0JWSqzactyYouq5XT93hKkLA3+ECR2fybXcRDNR8pRxcbKQxRSgGtZWoJPCOcZAvrQkb XAMYBejRShB13sCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6FA0E13326; Thu, 28 Aug 2025 08:29:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id uGtmFlQTsGhoKwAAD6G6ig (envelope-from ); Thu, 28 Aug 2025 08:29:08 +0000 Message-ID: Date: Thu, 28 Aug 2025 11:29:08 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] net: cadence: macb: Set upper 32bits of DMA ring buffer To: Nicolas Ferre , Stanimir Varbanov , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, Broadcom internal kernel review list , Andrew Lunn , "David S . Miller" , Eric Dumazet , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Andrea della Porta , Claudiu Beznea , Phil Elwell , Jonathan Bell , Dave Stevenson , stable@vger.kernel.org, Andrew Lunn , =?UTF-8?Q?Th=C3=A9o_Lebrun?= References: <20250822093440.53941-1-svarbanov@suse.de> <20250822093440.53941-2-svarbanov@suse.de> <20250825165310.64027275@kernel.org> <1ecd4a9a-d685-4bce-ad06-cc8878f0a165@suse.de> <3e1c2519-e5b3-4775-bb49-ec8f355ca4b2@microchip.com> Content-Language: en-US From: Stanimir Varbanov In-Reply-To: <3e1c2519-e5b3-4775-bb49-ec8f355ca4b2@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[25]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[dt,netdev]; R_RATELIMIT(0.00)[to_ip_from(RLx6y83x9aawq735t6wjdq6iwn)]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email] X-Spam-Flag: NO X-Spam-Level: X-Rspamd-Queue-Id: 93D7A21BED X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Score: -3.01 Hi Nicolas, On 8/26/25 12:13 PM, Nicolas Ferre wrote: > On 26/08/2025 at 10:35, Stanimir Varbanov wrote: >> Hi Jakub, >> >> On 8/26/25 2:53 AM, Jakub Kicinski wrote: >>> On Fri, 22 Aug 2025 12:34:36 +0300 Stanimir Varbanov wrote: >>>> In case of rx queue reset and 64bit capable hardware, set the upper >>>> 32bits of DMA ring buffer address. >>>> >>>> Cc: stable@vger.kernel.org # v4.6+ >>>> Fixes: 9ba723b081a2 ("net: macb: remove BUG_ON() and reset the queue >>>> to handle RX errors") >>>> Credits-to: Phil Elwell >>>> Credits-to: Jonathan Bell >>>> Signed-off-by: Stanimir Varbanov >>>> Reviewed-by: Andrew Lunn >>> >>>> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ >>>> ethernet/cadence/macb_main.c >>>> index ce95fad8cedd..36717e7e5811 100644 >>>> --- a/drivers/net/ethernet/cadence/macb_main.c >>>> +++ b/drivers/net/ethernet/cadence/macb_main.c >>>> @@ -1634,7 +1634,11 @@ static int macb_rx(struct macb_queue *queue, >>>> struct napi_struct *napi, >>>>               macb_writel(bp, NCR, ctrl & ~MACB_BIT(RE)); >>>> >>>>               macb_init_rx_ring(queue); >>>> -            queue_writel(queue, RBQP, queue->rx_ring_dma); >>>> +            queue_writel(queue, RBQP, lower_32_bits(queue- >>>> >rx_ring_dma)); >>>> +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT >>>> +            if (bp->hw_dma_cap & HW_DMA_CAP_64B) >>>> +                    macb_writel(bp, RBQPH, upper_32_bits(queue- >>>> >rx_ring_dma)); >>>> +#endif >>>> >>>>               macb_writel(bp, NCR, ctrl | MACB_BIT(RE)); >>>> >>> >>> Looks like a subset of Théo Lebrun's work: >>> https://lore.kernel.org/all/20250820-macb-fixes- >>> v4-0-23c399429164@bootlin.com/ >>> let's wait for his patches to get merged instead? >> >> No objections for this patch, it could be postponed. But the others from >> the series could be applied. > > Some cleanup by Théo, could interfere with sorting of compatibility > strings... Théo's series touches clk properties so I do not expect conflicts. regards, ~Stan