From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: Lizhi Xu <lizhi.xu@windriver.com>,
syzbot+a4976ce949df66b1ddf1@syzkaller.appspotmail.com
Cc: chao@kernel.org, jaegeuk@kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] f2fs: fix deadlock in f2f2_add_dentry
Date: Wed, 6 Sep 2023 21:56:03 +0900 [thread overview]
Message-ID: <c4d0bbf2-c4a8-cb2e-e941-a68a15cfb042@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20230825053732.3098387-1-lizhi.xu@windriver.com>
On 2023/08/25 14:37, Lizhi Xu wrote:
> @@ -736,12 +736,12 @@ int f2fs_add_regular_entry(struct inode *dir, const struct f2fs_filename *fname,
> f2fs_wait_on_page_writeback(dentry_page, DATA, true, true);
>
> if (inode) {
> - f2fs_down_write(&F2FS_I(inode)->i_sem);
> page = f2fs_init_inode_metadata(inode, dir, fname, NULL);
> if (IS_ERR(page)) {
> err = PTR_ERR(page);
> goto fail;
> }
> + f2fs_down_write(&F2FS_I(inode)->i_sem);
> }
Above change does not match below.
fail:
if (inode)
f2fs_up_write(&F2FS_I(inode)->i_sem);
>
> make_dentry_ptr_block(NULL, &d, dentry_blk);
next prev parent reply other threads:[~2023-09-06 12:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 3:55 [syzbot] [f2fs?] possible deadlock in f2fs_add_inline_entry syzbot
2023-08-24 15:55 ` syzbot
2023-08-25 1:08 ` Chao Yu
2023-08-25 1:47 ` syzbot
2023-08-25 5:37 ` [PATCH] f2fs: fix deadlock in f2f2_add_dentry Lizhi Xu
2023-08-25 10:41 ` Chao Yu
2023-08-26 2:58 ` [f2fs-dev] " Lizhi Xu
2023-09-06 12:56 ` Tetsuo Handa [this message]
2023-10-26 6:59 ` [syzbot] [f2fs?] possible deadlock in f2fs_add_inline_entry syzbot
2023-10-26 9:21 ` Aleksandr Nogikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4d0bbf2-c4a8-cb2e-e941-a68a15cfb042@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.xu@windriver.com \
--cc=syzbot+a4976ce949df66b1ddf1@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®