From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8613774068; Thu, 24 Oct 2024 03:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729739371; cv=none; b=Dzn9RL/FEJ8uybJXhh0KqltrND6qnotMUbvNWncXX6L5vIiZCXRfjJM4Eg76XNsL++3zYkgDRX/brRO6nQWV4nt1rT8udQrE/QNx/FQ3CFK/WYbcMvt8j/pn1dZ++CJnCYklW4eDHYYCXcjWjxxR/KnU6HP/x0E2gxorDncgx3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729739371; c=relaxed/simple; bh=bqGMO8gfXtzyHFpj1RRhYhjDD06u4grA5x3HgcM4/0Y=; h=Message-ID:Date:MIME-Version:CC:Subject:To:References:From: In-Reply-To:Content-Type; b=PHExxT+WH1AEaEnlqz3offoKDG+AwwKrhZpCiJlyyK+4SwuwM27CRucuYFYNqmN0L1Bo/wq/XOH8fGhRsaPlJsRo0PaHP/6MFwsbH3FG9BkYekcpMRPApNbbDyH57kS000LeWuwopjjcB08lmdz7oEWwCFUAZtgGfytooTSIYi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4XYrSw5t9gz1jvqk; Thu, 24 Oct 2024 11:08:00 +0800 (CST) Received: from kwepemm000007.china.huawei.com (unknown [7.193.23.189]) by mail.maildlp.com (Postfix) with ESMTPS id A848F1A0171; Thu, 24 Oct 2024 11:09:24 +0800 (CST) Received: from [10.67.120.192] (10.67.120.192) by kwepemm000007.china.huawei.com (7.193.23.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 24 Oct 2024 11:09:23 +0800 Message-ID: Date: Thu, 24 Oct 2024 11:09:22 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next 3/7] net: hibmcge: Add unicast frame filter supported in this module To: Andrew Lunn References: <20241023134213.3359092-1-shaojijie@huawei.com> <20241023134213.3359092-4-shaojijie@huawei.com> From: Jijie Shao In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm000007.china.huawei.com (7.193.23.189) on 2024/10/23 22:05, Andrew Lunn wrote: >> +static int hbg_add_mac_to_filter(struct hbg_priv *priv, const u8 *addr) >> +{ >> + u32 index; >> + >> + /* already exists */ >> + if (!hbg_get_index_from_mac_table(priv, addr, &index)) >> + return 0; >> + >> + for (index = 0; index < priv->filter.table_max_len; index++) >> + if (is_zero_ether_addr(priv->filter.mac_table[index].addr)) { >> + hbg_set_mac_to_mac_table(priv, index, addr); >> + return 0; >> + } >> + >> + if (!priv->filter.table_overflow) { >> + priv->filter.table_overflow = true; >> + hbg_update_promisc_mode(priv->netdev); >> + dev_info(&priv->pdev->dev, "mac table is overflow\n"); >> + } >> + >> + return -ENOSPC; > I _think_ this is wrong. If you run out of hardware resources, you > should change the interface to promiscuous mode and let the stack do > the filtering. Offloading it to hardware is just an acceleration, > nothing more. > > Andrew In hbg_update_promisc_mode(): priv->filter.enabled = !(priv->filter.table_overflow || (netdev->flags & IFF_PROMISC)); hbg_hw_set_mac_filter_enable(priv, priv->filter.enabled); if table_overflow， and netdev->flags not set IFF_PROMISC， the priv->filter.enabled will set to false， Then， The MAC filter will be closed. I think it's probably the same thing you said In this: + if (!priv->filter.table_overflow) { + priv->filter.table_overflow = true; + hbg_update_promisc_mode(priv->netdev); + dev_info(&priv->pdev->dev, "mac table is overflow\n"); + } + + return -ENOSPC; When the first overflow occurs, a log is printed, the MAC filter will be disabled, and -ENOSPC is returned. If continue to add MAC addresses, -ENOSPC is returned only. Thanks， Jijie Shao