From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752381AbeBHVxF (ORCPT ); Thu, 8 Feb 2018 16:53:05 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:54096 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752126AbeBHVxD (ORCPT ); Thu, 8 Feb 2018 16:53:03 -0500 X-Auth-Info: WnoivQky53usfjDs8rxL7JSMQCNkuoeOI1RjffCpOqE= Subject: Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error To: Marc Kleine-Budde , Heiko Schocher , linux-can@vger.kernel.org Cc: Markus Marb , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wolfgang Grandegger References: <20180208064748.17985-1-hs@denx.de> <59322f7d-4207-a5a4-89b5-dff1634e4183@pengutronix.de> From: Marek Vasut Message-ID: Date: Thu, 8 Feb 2018 22:44:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/2018 10:33 PM, Marc Kleine-Budde wrote: > On 02/08/2018 08:22 PM, Marek Vasut wrote: >> On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote: >>> On 02/08/2018 07:47 AM, Heiko Schocher wrote: >>>> the driver reads in the ISR first the IRQpending register, >>>> and clears after that in a write *all* bits in it. >>>> >>>> It could happen that the isr register raise bits between >>>> this 2 register accesses, which leads in lost bits ... >>>> >>>> In case it clears "TX message sent successfully", the driver >>>> never sends any Tx data, and buffers to userspace run over. >>>> >>>> Fixed this: >>>> clear only the bits in the IRQpending register, the >>>> driver had read. >>>> >>>> Signed-off-by: Heiko Schocher >>>> Reviewed-by: Marek Vasut >>> >>> Applied both to linux-can. >> >> Can you also apply them to stable, so they get into 4.9.x etc ? > > I've already added stable on Cc, so they will be picked up by the stable > maintainers. Thanks! -- Best regards, Marek Vasut