From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Mark Brown <broonie@kernel.org>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Alex Deucher <Alexander.Deucher@amd.com>,
Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Ravulapati Vishnu vardhan rao
<Vishnuvardhanrao.Ravulapati@amd.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ASoC: amd: fix acpi dependency kernel warning
Date: Sun, 28 Mar 2021 23:25:40 +0530 [thread overview]
Message-ID: <c4d5e624-d922-d338-ca35-72ee06cec08a@amd.com> (raw)
In-Reply-To: <CAK8P3a0aM4GRZ62TvNpwtMY0Bw7JGJNVs55UkpdBVYeKgWhMaQ@mail.gmail.com>
On 3/26/21 10:14 PM, Arnd Bergmann wrote:
> On Fri, Mar 26, 2021 at 5:44 PM Vijendar Mukunda
> <Vijendar.Mukunda@amd.com> wrote:
>>
>> Fix ACPI dependency kernel warning produced by powerpc
>> allyesconfig.
>>
>> sound/soc/amd/acp-da7219-max98357a.c:684:28: warning:
>> 'cz_rt5682_card' defined but not used [-Wunused-variable]
>>
>> sound/soc/amd/acp-da7219-max98357a.c:671:28: warning: 'cz_card'
>> defined but not used [-Wunused-variable]
>
> I would suggest simply dropping the unnecessary #ifdef and
> ACPI_PTR() guard.
>
> It might be helpful to hide the Kconfig submenu under
> 'depends on X86 || COMPILE_TEST'.
>
> Arnd
>
Will drop the unnecessary safegaurd and will upload the new version.
next prev parent reply other threads:[~2021-03-28 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 16:44 [PATCH RESEND 1/2] ASoC: amd: update spdx license for acp machine driver Vijendar Mukunda
2021-03-26 16:44 ` [PATCH 2/2] ASoC: amd: fix acpi dependency kernel warning Vijendar Mukunda
2021-03-26 16:44 ` Arnd Bergmann
2021-03-28 17:55 ` Mukunda,Vijendar [this message]
2021-03-29 19:58 ` [PATCH RESEND 1/2] ASoC: amd: update spdx license for acp machine driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4d5e624-d922-d338-ca35-72ee06cec08a@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®