From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D78625D53B for ; Sat, 10 Jan 2026 20:12:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768075952; cv=none; b=sQSMRg16ySggPzVB2Y+eEQ+4O8vw1uc5q86KBXNxAT2WWSgoi7KYs4wO729y/Sue8RIL80e5ZdSt019w7F3x2qosIL03TJBjKCtlvdLHR06vmXeStpEanRb/ARHmaCFRUF/RIqxUP0BFQcJ34nhD+8zwURKSCG5DKBy4MzmL/ns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768075952; c=relaxed/simple; bh=gqmDPrBUMH4/Iik7/Uer6th3Sz9nY2P2fa3OEefj3lw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=BCWDnbW26eiPXbozVWQwA2eR+l26RJwwtiBCxl+Q7VqVRRNSXF4P+s+H8vRDoKN01wDxVBxvAJYQ4UH3sovCY/2y7voHZb5N6k8ZdRS55aT/AK2uVugzhdCEzvJRvtkNd3UljX7l9BP2AgRdlSi7d1s+9O+LSkhBp5/nvxgEgpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X0tycxLm; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X0tycxLm" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-b8708930695so16205966b.3 for ; Sat, 10 Jan 2026 12:12:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768075949; x=1768680749; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=gqmDPrBUMH4/Iik7/Uer6th3Sz9nY2P2fa3OEefj3lw=; b=X0tycxLmRyDKyXoHkjojbT2v4MzBuslSFxT/ppG9rLB6T+dB2ROAqBvBOXvLtMJDAH 9lOaoaneTHiiJQGtP7F3cWGBXKBeREw2shKY1Yr5R4HoLUaFCsFtsUFdZL9akvrDIjMN X7qbsCMdwIMb4TM/UfGlWB9glOIppSXTLFmOtwyu2VhzCFLE2Z7QYTBgDNWGNtjUSicI PlGC5cHxxPT4pXLW6fTLVGp8T9kihWd35gO09nhSkGlJqDxTso1jUKimM05HsVJP5eEz hBKHfqNFhSfX8dUd6xA+MHioWHpKfmxnDmDBjFObaRq8cMrzn0mHoobCZ2V9FXWP6yB6 yYGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768075949; x=1768680749; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gqmDPrBUMH4/Iik7/Uer6th3Sz9nY2P2fa3OEefj3lw=; b=LyGb+YfcRDjZIcJPkn4qA7pX4aU0mG3QWNIfKmaSPbz38ZT/b4Y3/qfryBNsNugCPb k6log5CNCah3z88HdcikjRntx/GdBMUmCR1vffygFj9zbOEkndOqzctcn42XGguvDkRV B3CHKy4GKmMBnguSKTL/zHj3r/Qv6blrX+kBkwvct7ZX1tGaSr0nmIVic18tH2ZCUGWf cz57nMdMTSsKmKJSKRA15Db7xKNGaAKFPxyGXhxCyA89LKulXf5dq8Qa8o4aK8cqLk0H SLxbC7z/wOQQoNBZ7zMUPBfKgFTnMaWwOr6UpHHBZysxW4KoY1CYXua5sRjZoiqV/x2v J+7Q== X-Forwarded-Encrypted: i=1; AJvYcCULMrzRMclTxvbkoO81i+9oIorJNV7ddoxSUxL/Ew9h6rsjRFjsOO0PkV/V2T91y8p5l1xiQLq57hqkORQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyjO+v0A3BI/6OXsOHiPJa5d3qkDoXic+JN8/c1CVt6KEfVImmH mGrtULXDqyq9TTa5OAaE2sBDACJaX62FLZMkn9ffw+LRbDwTuzr/N6yM X-Gm-Gg: AY/fxX4zDmAlu13hLVqoo9IRETr6qG8yPoxwkTSiHZUDe7CQXatRqFY7eCoM8BKDTo7 GKIXHOX0DrmRYgFxC0mu1CTkNx7CJ3RGrsQTw9yHkc3NNPHC4zRf5bU5zsDJT3ARfZn52G8sExH QY/zwbvdskpG+DJ+ONCZk4Dd9Y2tGF42GD+079LTwL687yNoyC43dnT8/MnuWbHAOcDxnKYLuDb +loQWzzctzDd1A427Brt04C+XByLyqBU9CGSKk4OjmiHPhksPpDeP7ErtIRY7IgCbZ6hP7PG+rV ljbo3ah5QtwyxS20X9zqle5l67MuqrmnRQc+8/nAmbJyv0sDhQPBKZbck2clDF5hP1dmi8ilwBH CR7QjNOpP+4ryIO8orZVE0LFcbXVu5IpLHUGGbVtDi1eF38RuMTuE0aTZlRkokWsyv2JNCuxs3j rBLbl5YrKm/eKtBnKcED44bz3uXF92 X-Google-Smtp-Source: AGHT+IEqyXVUoiPOwCm8thcx8YpK6aUWILpHTpo0KAnsDDgdi8HgiHbo0Og3YdF+jqmLDC7wVbzBIg== X-Received: by 2002:a17:906:d54d:b0:b83:95d7:9d50 with SMTP id a640c23a62f3a-b8445179fc5mr1359399366b.38.1768075948938; Sat, 10 Jan 2026 12:12:28 -0800 (PST) Received: from giga-mm.home ([2a02:1210:8642:2b00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b84591b6240sm922872866b.10.2026.01.10.12.12.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jan 2026 12:12:28 -0800 (PST) Message-ID: Subject: Re: [PATCH] ASoC: cs4271: Fix resource leak in cs4271_soc_resume() From: Alexander Sverdlin To: Harshit Mogalapalli , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Herve Codina , Pascal Huerst , linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org Cc: dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org, error27@gmail.com Date: Sat, 10 Jan 2026 21:12:28 +0100 In-Reply-To: <20260110195337.2522347-1-harshit.m.mogalapalli@oracle.com> References: <20260110195337.2522347-1-harshit.m.mogalapalli@oracle.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Thanks for the patch Harshit! On Sat, 2026-01-10 at 11:53 -0800, Harshit Mogalapalli wrote: > Smatch detects this resource leak: >=20 > sound/soc/codecs/cs4271.c:548 cs4271_soc_resume() warn: > =C2=A0'cs4271->clk' from clk_prepare_enable() not released on lines: 540,= 546. >=20 > Instead of direct returns, unprepare the clock and disable regulators on > the error paths. >=20 > Fixes: cf6bf51b5325 ("ASoC: cs4271: Add support for the external mclk") > Fixes: 9a397f473657 ("ASoC: cs4271: add regulator consumer support") > Signed-off-by: Harshit Mogalapalli Reviewed-by: Alexander Sverdlin > --- > Only compile tested. > --- > =C2=A0sound/soc/codecs/cs4271.c | 12 +++++++++--- > =C2=A01 file changed, 9 insertions(+), 3 deletions(-) --=20 Alexander Sverdlin.