mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Harshal Wadhwa <embedkari167@gmail.com>
Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] selftests: firmware: Add details in error logging
Date: Thu, 24 Jul 2025 14:29:29 -0600	[thread overview]
Message-ID: <c4da142b-07c5-43a8-a12f-6e403d994a4e@linuxfoundation.org> (raw)
In-Reply-To: <aH0zxwC8eJ2GhcXu@harshPC>

On 7/20/25 12:21, Harshal Wadhwa wrote:
> On Mon, Jul 14, 2025 at 03:39:47PM -0600, Shuah Khan wrote:
>> On 7/14/25 15:26, Harshal wrote:
>>> Specify details in logs of failed cases
>>
>> How about changing the above to:
>>
>> Improve error messages adding details on failuires
> Will change this in next patch
> 
>>>    	fd = open(sys_path, O_WRONLY);
>>>    	if (fd < 0)
>>> -		die("open failed: %s\n",
>>> +		die("open of sys_path failed: %s\n",
>>
>> Why not just use sys_path as a input parameter to die()?
> Sure, that's great. Is there a way to test these changes ?

The same way you tested your v2 patch? How did you test this
patch?

thanks,
-- Shuah

      reply	other threads:[~2025-07-24 20:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-14 21:26 Harshal
2025-07-14 21:39 ` Shuah Khan
2025-07-20 18:21   ` Harshal Wadhwa
2025-07-24 20:29     ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4da142b-07c5-43a8-a12f-6e403d994a4e@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=embedkari167@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®