mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Can Guo <quic_cang@quicinc.com>
To: Bart Van Assche <bvanassche@acm.org>, <mani@kernel.org>,
	<stanley.chu@mediatek.com>, <adrian.hunter@intel.com>,
	<beanhuo@micron.com>, <avri.altman@wdc.com>,
	<junwoo80.lee@samsung.com>, <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	Lu Hongfei <luhongfei@vivo.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] scsi: ufs: ufs-sysfs: Expose UFS power info
Date: Thu, 2 Nov 2023 09:48:58 +0800	[thread overview]
Message-ID: <c4daed9a-4d76-a248-d560-edb851b4927c@quicinc.com> (raw)
In-Reply-To: <ebdbb2eb-0339-40a7-9697-6148fcda81a2@acm.org>

Hi Bart,

On 11/2/2023 1:07 AM, Bart Van Assche wrote:
> On 10/31/23 21:00, Can Guo wrote:
>> +    return sysfs_emit(buf, "%s\n", hba->pwr_info.hs_rate ?
>> + ufshcd_ufs_hs_gear_to_string(hba->pwr_info.gear_rx) :
>> + ufshcd_ufs_pwm_gear_to_string(hba->pwr_info.gear_rx));
>> +}
>
> A nit: this is not how kernel code should be indented. I think that
> "ufshcd_..." should be aligned with "buf,".
>
> Anyway:
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>


Will address it in next version.


Thanks,

Can Guo.


      reply	other threads:[~2023-11-02  1:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-01  4:00 Can Guo
2023-11-01  5:12 ` Manivannan Sadhasivam
2023-11-02  1:49   ` Can Guo
2023-11-01 16:56 ` Bean Huo
2023-11-01 17:07 ` Bart Van Assche
2023-11-02  1:48   ` Can Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4daed9a-4d76-a248-d560-edb851b4927c@quicinc.com \
    --to=quic_cang@quicinc.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=jejb@linux.ibm.com \
    --cc=junwoo80.lee@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=luhongfei@vivo.com \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®