From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754017AbdEJQFA (ORCPT <rfc822;w@1wt.eu>);
        Wed, 10 May 2017 12:05:00 -0400
Received: from foss.arm.com ([217.140.101.70]:39640 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753310AbdEJQE7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 May 2017 12:04:59 -0400
Subject: Re: [PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm
To: Stefan Wahren <stefan.wahren@i2se.com>,
        Phil Elwell <phil@raspberrypi.org>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
References: <20170510132620.19685-1-marc.zyngier@arm.com>
 <2c3f16ea-8806-9ae8-9bae-02e198a59092@arm.com>
 <27076f41-1616-ea16-6422-11692f95bdec@raspberrypi.org>
 <9334afc8-ddf1-b3ec-6560-ff720f8b82dc@arm.com>
 <55d1d773-7220-6448-5ef4-e9b5595c0f68@raspberrypi.org>
 <5ea27eff-8495-63d1-abd1-eef283ea2b5d@arm.com>
 <13c4ffa2-20e5-2775-ceae-e6701a5ba554@i2se.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        Jason Cooper <jason@lakedaemon.net>,
        Scott Branden <sbranden@broadcom.com>, Ray Jui <rjui@broadcom.com>,
        Eric Anholt <eric@anholt.net>, Thomas Gleixner <tglx@linutronix.de>
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <c4de0295-fff0-01e7-173f-a4e61b55ae4f@arm.com>
Date: Wed, 10 May 2017 17:04:55 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <13c4ffa2-20e5-2775-ceae-e6701a5ba554@i2se.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/05/17 16:53, Stefan Wahren wrote:
> Am 10.05.2017 um 17:38 schrieb Marc Zyngier:
>> On 10/05/17 16:32, Phil Elwell wrote:
>>> On 10/05/2017 16:31, Marc Zyngier wrote:
>>>> On 10/05/17 16:07, Phil Elwell wrote:
>>>>> On 10/05/2017 14:32, Marc Zyngier wrote:
>>>>>> On 10/05/17 14:26, Marc Zyngier wrote:
>>>>>>> One of the RPi-2/3 irqchip's key features is that it contains some
>>>>>>> SMP startup code for the 32bit ARM architecture version. The only
>>>>>>> reason I can imagine for this is "RPi is special".
>>>>>>>
>>>>>>> Let's move this code where it belongs (in the platform support code),
>>>>>>> creating a shared include file for this purpose.
>>>>>>>
>>>>>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>>>>>> Also:
>>>>>> Fixes: 41f4988cc287 ("irqchip/bcm2836: Add SMP support for the 2836")
>>>>>>
>>>>>> 	M.
>>>>>>
>>>>> The patch has some checkpatch warnings, but otherwise:
>>>> Bah...
>>>>
>>>> WARNING: line over 80 characters
>>>> #51: FILE: arch/arm/mach-bcm/board_bcm2835.c:30:
>>>> +static int bcm2836_smp_boot_secondary(unsigned int cpu, struct task_struct *idle)
>>>>
>>>> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
>>>> #194: 
>>>> new file mode 100644
>>>>
>>>> Yup, the checkpatch stamp of approval. My screen has stopped being 
>>>> limited to 80 chars at some point between 1989 and 1991. As for the
>>>> MAINTAINERS file, that's probably for the maintainers to pick it up.
>>>>
>>>>> Reviewed-by: Phil Elwell <phil@raspberrypi.org>
>>>>> Tested-by: Phil Elwell <phil@raspberrypi.org>
>>>> Thanks. I assume you'll respin your DSB/SEV fix on top of this?
>>> Yes - how does one manage the timing of interdependent patches?
> 
> Since Phil's patch is a critical bugfix for the near future. I prefer to
> have it in 4.12.

I don't think anyone is opposed to having this in 4.12 immediately.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...