From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B844C25EFBB; Fri, 31 Oct 2025 16:19:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761927576; cv=none; b=Wu2fAHLpXOiLM27bjrgLRTX/qUc5JKuVRUYpP5KGm8Jxr2ZlB3MQh5L9wdLtWr4+OxZJEmIcfucXgqY+6Qt5r8Q2xoOGibPleTloNENNJmUwXWjSxB3dVYoYiXII57TghpCUyLU+R1suWNLF8vmxbFdEFlxAhC954J0NF8Q0BA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761927576; c=relaxed/simple; bh=8jSGa5FBFz+lpGdyBN62ollii75N0UH/s7FBkDBu8d0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MMZYUJByMRunkym43SlSMZaC8iX5XaqkncjB/B1aRavPG8Ll4EkaBgT89Sq3PLr7XNA+RnnNYY0XK/Z+o8x1zjUzrY8KAw3p363y2xjoi4jiOdMTQk7ZVXubY9ZsfrC8uY5n+EMw+d0tqQOIC7JxSBpvXOL28DEGRPQG/pLyeWw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=Sh2uVxHl; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Sh2uVxHl" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=h8x00BdGOX6ejpZ5GnXP3pUZyObW3nrJsk+6UQ17jcY=; b=Sh2uVxHllkyCKnq3Vo3xPtsgQn pBE2/nBCVgPoZmVueMYMD54kiE7r4o/JXGvhClZkerKo39qO9REi1EeDtIyVRFr8R65zzN5TvzDZ2 20vajedRanVt/fe6/uCsAQppnw6YAPuktdu6y6wUNvEMUDm/NDX1AjrRVrnjFprPxngs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1vErqS-00Cc8U-Gi; Fri, 31 Oct 2025 17:19:20 +0100 Date: Fri, 31 Oct 2025 17:19:20 +0100 From: Andrew Lunn To: Maxime Chevallier Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Simon Horman , Boon Khai Ng , Alexis =?iso-8859-1?Q?Lothor=E9?= , Thomas Petazzoni , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 4/4] net: altera-tse: Init PCS and phylink before registering netdev Message-ID: References: <20251030102418.114518-1-maxime.chevallier@bootlin.com> <20251030102418.114518-5-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251030102418.114518-5-maxime.chevallier@bootlin.com> On Thu, Oct 30, 2025 at 11:24:17AM +0100, Maxime Chevallier wrote: > register_netdev() must be done only once all resources are ready, as > they may be used in .ndo_open() immediately upon registration. > > Move the lynx PCS and phylink initialisation before registerng the > netdevice. We also remove the call to netif_carrier_off(), as phylink > takes care of that. > > Signed-off-by: Maxime Chevallier Reviewed-by: Andrew Lunn Andrew