From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
<akpm@linux-foundation.org>, <hughd@google.com>
Cc: <willy@infradead.org>, <david@redhat.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] Improve the tmpfs large folio read performance
Date: Wed, 16 Oct 2024 19:47:14 +0800 [thread overview]
Message-ID: <c4e4480d-bed3-4a4a-b07f-496006c5785f@huawei.com> (raw)
In-Reply-To: <cover.1729072803.git.baolin.wang@linux.alibaba.com>
On 2024/10/16 18:09, Baolin Wang wrote:
> The tmpfs has already supported the PMD-sized large folios, but the tmpfs
> read operation still performs copying at the PAGE SIZE granularity, which
> is not perfect. This patch changes to copy data at the folio granularity,
> which can improve the read performance.
>
> Use 'fio bs=64k' to read a 1G tmpfs file populated with 2M THPs, and I can
> see about 20% performance improvement, and no regression with bs=4k. I
> also did some functional test with the xfstests suite, and I did not find
> any regressions with the following xfstests config.
> FSTYP=tmpfs
> export TEST_DIR=/mnt/tempfs_mnt
> export TEST_DEV=/mnt/tempfs_mnt
> export SCRATCH_MNT=/mnt/scratchdir
> export SCRATCH_DEV=/mnt/scratchdir
>
Oh,we make same changes, my bonnie test(./bonnie -d /tmp -s 1024) see
similar improvement(19.2% with huge=always) with out inner changes :)
> Baolin Wang (2):
> mm: shmem: update iocb->ki_pos directly to simplify tmpfs read logic
> mm: shmem: improve the tmpfs large folio read performance
>
> mm/shmem.c | 54 ++++++++++++++++++++++--------------------------------
> 1 file changed, 22 insertions(+), 32 deletions(-)
>
prev parent reply other threads:[~2024-10-16 11:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 10:09 Baolin Wang
2024-10-16 10:09 ` [PATCH 1/2] mm: shmem: update iocb->ki_pos directly to simplify tmpfs read logic Baolin Wang
2024-10-16 12:34 ` Kefeng Wang
2024-10-17 2:45 ` Baolin Wang
2024-10-16 10:09 ` [PATCH 2/2] mm: shmem: improve the tmpfs large folio read performance Baolin Wang
2024-10-16 12:36 ` Kefeng Wang
2024-10-17 2:46 ` Baolin Wang
2024-10-16 15:37 ` Matthew Wilcox
2024-10-16 17:33 ` Yang Shi
2024-10-17 3:25 ` Baolin Wang
2024-10-17 16:48 ` Yang Shi
2024-10-18 1:45 ` Baolin Wang
2024-10-16 11:47 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4e4480d-bed3-4a4a-b07f-496006c5785f@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®