mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	<shuah@kernel.org>, <fenghua.yu@intel.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>, <tony.luck@intel.com>
Subject: Re: [PATCH v3 1/2] selftests/resctrl: Adjust effective L3 cache size with SNC enabled
Date: Tue, 2 Jul 2024 15:20:22 -0700	[thread overview]
Message-ID: <c4e4d913-2bdb-4451-be7d-0fee80ae0c66@intel.com> (raw)
In-Reply-To: <1e6ed2bbbc7716a1606865b8e890afdfcea7ca1d.1719842207.git.maciej.wieczor-retman@intel.com>

Hi Maciej,

On 7/1/24 7:18 AM, Maciej Wieczor-Retman wrote:
...
> +int snc_nodes_per_l3_cache(void)
> +{
> +	int node_cpus, cache_cpus, i, ret = 1;
> +
> +	node_cpus = count_sys_bitmap_bits("/sys/devices/system/node/node0/cpumap");
> +	cache_cpus = count_sys_bitmap_bits("/sys/devices/system/cpu/cpu0/cache/index3/shared_cpu_map");
> +
> +	if (!node_cpus || !cache_cpus) {
> +		ksft_print_msg("Could not determine Sub-NUMA Cluster mode!\n");

nit: could you please check this series and remove exclamation marks from the messages
printed to user space? Just stating the error should be sufficient.

Reinette

  reply	other threads:[~2024-07-02 22:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 14:17 [PATCH v3 0/2] selftests/resctrl: SNC kernel support discovery Maciej Wieczor-Retman
2024-07-01 14:18 ` [PATCH v3 1/2] selftests/resctrl: Adjust effective L3 cache size with SNC enabled Maciej Wieczor-Retman
2024-07-02 22:20   ` Reinette Chatre [this message]
2024-07-03  6:43     ` Maciej Wieczor-Retman
2024-07-01 14:18 ` [PATCH v3 2/2] selftests/resctrl: Adjust SNC support messages Maciej Wieczor-Retman
2024-07-01 16:04   ` Luck, Tony
2024-07-02 21:26     ` Reinette Chatre
2024-07-02 21:46       ` Tony Luck
2024-07-02 22:01         ` Reinette Chatre
2024-07-02 22:03           ` Luck, Tony
2024-07-03  6:44             ` Maciej Wieczor-Retman
2024-07-03  6:50     ` Maciej Wieczor-Retman
2024-07-02 22:21   ` Reinette Chatre
2024-07-03  7:43     ` Maciej Wieczór-Retman
2024-07-03 20:51       ` Reinette Chatre
2024-07-04  7:23         ` Maciej Wieczor-Retman
2024-07-08 16:39           ` Reinette Chatre
2024-07-09  7:49             ` Maciej Wieczor-Retman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4e4d913-2bdb-4451-be7d-0fee80ae0c66@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=shuah@kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®