From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F7FAC433E0 for ; Fri, 15 Jan 2021 05:59:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73F82239FC for ; Fri, 15 Jan 2021 05:59:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728742AbhAOF7J (ORCPT ); Fri, 15 Jan 2021 00:59:09 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:10724 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726019AbhAOF7H (ORCPT ); Fri, 15 Jan 2021 00:59:07 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DH9S171rYzl3sR; Fri, 15 Jan 2021 13:57:05 +0800 (CST) Received: from [10.174.176.61] (10.174.176.61) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Fri, 15 Jan 2021 13:58:20 +0800 Subject: Re: [PATCH v2] cgroup-v1: add disabled controller check in cgroup1_parse_param() To: Tejun Heo References: <20201218061755.121205-1-chenzhou10@huawei.com> <7804658e-7644-8edb-5ca8-0c97389c8c62@huawei.com> CC: =?UTF-8?Q?Michal_Koutn=c3=bd?= , , , , From: chenzhou Message-ID: Date: Fri, 15 Jan 2021 13:58:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.176.61] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/1/15 11:17, Tejun Heo wrote: > Hello, > > On Fri, Jan 15, 2021 at 09:55:43AM +0800, chenzhou wrote: >> Yeah, this will select all enabled controllers, but which doesn't the behavior we want. >> I think the case should return error with information "Disabled controller xx" rather than >> attaching all the other enabled controllers. >> >> For example, boot with cgroup_no_v1=cpu, and then mount with >> "mount -t cgroup -o cpu cpu /sys/fs/cgroup/cpu", then all enabled controllers will >> be attached expect cpu. > Okay, that explanation actually makes sense. Can you please update the > description to include what's broken and how it's being fixed? It really > isn't clear what the patch is trying to achieve from the current > description. Ok, will update the description. > > Thanks. >