From: Markus Elfring <Markus.Elfring@web.de>
To: linux-nfs@vger.kernel.org, Anna Schumaker <anna@kernel.org>,
Trond Myklebust <trondmy@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
Christoph Hellwig <hch@lst.de>,
Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH] NFS: Use common error handling code in nfs_sysfs_init()
Date: Thu, 11 Jun 2026 13:45:12 +0200 [thread overview]
Message-ID: <c4e92afa-518b-4111-a750-66206e5e752e@web.de> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 11 Jun 2026 13:40:30 +0200
Use an additional label so that a bit of exception handling can be better
reused at the end of this function implementation.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/nfs/sysfs.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/fs/nfs/sysfs.c b/fs/nfs/sysfs.c
index 3a197252a132..c4ccaa6fe87f 100644
--- a/fs/nfs/sysfs.c
+++ b/fs/nfs/sysfs.c
@@ -49,22 +49,22 @@ int nfs_sysfs_init(void)
return -ENOMEM;
ret = kobject_set_name(&nfs_kset->kobj, "nfs");
- if (ret) {
- kfree(nfs_kset);
- return ret;
- }
+ if (ret)
+ goto free_kset;
nfs_kset->kobj.parent = fs_kobj;
nfs_kset->kobj.ktype = &nfs_kset_type;
nfs_kset->kobj.kset = NULL;
ret = kset_register(nfs_kset);
- if (ret) {
- kfree(nfs_kset);
- return ret;
- }
+ if (ret)
+ goto free_kset;
return 0;
+
+free_kset:
+ kfree(nfs_kset);
+ return ret;
}
void nfs_sysfs_exit(void)
--
2.54.0
reply other threads:[~2026-06-11 11:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4e92afa-518b-4111-a750-66206e5e752e@web.de \
--to=markus.elfring@web.de \
--cc=anna@kernel.org \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®