From: Thomas Richard <thomas.richard@bootlin.com>
To: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>, Lee Jones <lee@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
thomas.petazzoni@bootlin.com, blake.vermeer@keysight.com
Subject: Re: [PATCH v2 1/2] hwmon: Add Congatec Board Controller monitoring driver
Date: Fri, 15 Nov 2024 15:00:27 +0100 [thread overview]
Message-ID: <c4eb5a59-4551-476a-aa03-06849dc9680e@bootlin.com> (raw)
In-Reply-To: <609715ff-973a-484d-9267-ff80be7e36f3@roeck-us.net>
On 11/11/24 20:31, Guenter Roeck wrote:
>
> I don't understand why this would be needed anyway. The current channel
> index is well known, so adding or subtracting a constant should do it.
My first idea to use this macro was to avoid issue if a new voltage
sensor is added in the future.
But it's useless. If in a new generation of Board Controller a voltage
sensor is added, it will be added at the end of the list.
But it doesn't exist for now, so no need to take care.
I'll just add a constant for curr sensors.
Regards,
Thomas
next prev parent reply other threads:[~2024-11-15 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 15:08 [PATCH v2 0/2] Enable sensors support for the Congatec Board Controller Thomas Richard
2024-11-08 15:08 ` [PATCH v2 1/2] hwmon: Add Congatec Board Controller monitoring driver Thomas Richard
2024-11-11 19:31 ` Guenter Roeck
2024-11-15 14:00 ` Thomas Richard [this message]
2024-11-15 14:14 ` Guenter Roeck
2024-11-08 15:08 ` [PATCH v2 2/2] mfd: cgbc: add a hwmon cell Thomas Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4eb5a59-4551-476a-aa03-06849dc9680e@bootlin.com \
--to=thomas.richard@bootlin.com \
--cc=blake.vermeer@keysight.com \
--cc=jdelvare@suse.com \
--cc=lee@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®