From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jishnu Prakash <quic_jprakash@quicinc.com>,
agross@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
Jonathan.Cameron@huawei.com, sboyd@kernel.org,
dmitry.baryshkov@linaro.org, quic_subbaram@quicinc.com,
quic_collinsd@quicinc.com, quic_kamalw@quicinc.com,
marijn.suijten@somainline.org, andriy.shevchenko@linux.intel.com,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Luca Weiss <luca@z3ntu.xyz>,
linux-iio@vger.kernel.org, linux-arm-msm@vger.kernel.org
Cc: linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH 06/11] iio: adc: Add QCOM PMIC5 Gen3 ADC bindings
Date: Mon, 23 Oct 2023 08:36:48 +0200 [thread overview]
Message-ID: <c4ef9cac-15ac-4c2c-9f9a-cb9e740e2900@linaro.org> (raw)
In-Reply-To: <99070bce-6188-82eb-c92c-cf7a323394e2@quicinc.com>
On 23/10/2023 08:14, Jishnu Prakash wrote:
> Hi Krzysztof,
>
> On 7/9/2023 10:53 PM, Krzysztof Kozlowski wrote:
>> On 08/07/2023 09:28, Jishnu Prakash wrote:
>>> For the PMIC5-Gen3 type PMICs, ADC peripheral is present in HW for the
>>> following PMICs: PMK8550, PM8550, PM8550B and PM8550VX PMICs.
>>> It is similar to PMIC5-Gen2, with SW communication to ADCs on all PMICs
>>> going through PBS firmware through a single register interface. This
>>> interface is implemented on an SDAM peripheral on the master PMIC PMK8550
>>> rather than a dedicated ADC peripheral.
>>>
>>> Signed-off-by: Jishnu Prakash <quic_jprakash@quicinc.com>
>>> ---
>>> properties:
>>> compatible:
>>> @@ -27,10 +27,11 @@ properties:
>>> - qcom,spmi-adc5
>>> - qcom,spmi-adc-rev2
>>> - qcom,spmi-adc5-gen2
>>> + - qcom,spmi-adc5-gen3
>>
>> This could be ordered...
>
>
> Yes, will do that in the next patchset.
>
>
>>>
>>> reg:
>>> description: VADC base address in the SPMI PMIC register map
>>> - maxItems: 1
>>> + minItems: 1
>> Why? This does not make any sense. With previous patches it looks like
>> random set of changes.
>
>
> The idea here is to convey that reg can have multiple values for ADC5
> Gen3 as there can be more than one peripheral used for ADC, so there can
> be multiple base addresses. I'll try to make this more clear in the next
> patchset.
You cannot remove constraints from an entry.
>
>
>>
>>
>>>
>>> '#address-cells':
>>> const: 1
>>> @@ -38,6 +39,12 @@ properties:
>>> '#size-cells':
>>> const: 0
>>>
>>>
>>> + qcom,adc-tm-type:
>>> + description: |
>>> + Indicates if ADC_TM monitoring is done on this channel.
>> Description does not match property name.
>
>
> You mean it sounds more like an enum which can take several values
> rather than just a boolean? I can update it to "qcom,adc-tm" if that
> looks better.
The property name suggests this is type of monitoring. Property
description says this will enable ADC_TM monitoring. These two do not match.
Except that I wonder now whether this is a property of hardware at
all... What is this monitoring? By the driver?
...
>>> then:
>>> patternProperties:
>>> @@ -299,7 +315,7 @@ examples:
>>> label = "xo_therm";
>>> };
>>>
>>> - channel@47 {
>>> + channel@147 {
>> Why?
>
>
> It would be needed if this channel number was supposed to be the virtual
> channel number made by combining PMIC SID and actual channel
> number....but I could drop it for now and do it in a separate fix as
> Jonathan suggested.
>
>
>>
>>> reg = <PM8350_ADC5_GEN2_AMUX_THM4_100K_PU(1)>;
>>> qcom,ratiometric;
>>> qcom,hw-settle-time = <200>;
>>> @@ -307,3 +323,80 @@ examples:
>>> };
>>> };
>>> };
>>> +
>>> + - |
>>> + #include <dt-bindings/iio/qcom,spmi-adc5-gen3-pmk8550.h>
>>> + #include <dt-bindings/iio/qcom,spmi-adc5-gen3-pm8550.h>
>>> + #include <dt-bindings/iio/qcom,spmi-adc5-gen3-pm8550b.h>
>>> + #include <dt-bindings/iio/qcom,spmi-adc5-gen3-pm8550vx.h>
>>> +
>>> + pmic {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + /* VADC node */
>>> + pmk8550_vadc: vadc@9000 {
>>> + compatible = "qcom,spmi-adc5-gen3";
>> Don't add new examples which differ only in compatible.
>
>
> This example does have differences unique to ADC5 Gen3 such as use of
> "#thermal-sensor-cells" and "qcom,adc-tm-type" properties....to make it
> clearer, I'll delete some of the excess nodes which don't highlight
> these differences.
>
>
>>
>>
>>> diff --git a/include/dt-bindings/iio/qcom,spmi-adc5-gen3-pm8550.h b/include/dt-bindings/iio/qcom,spmi-adc5-gen3-pm8550.h
>>> new file mode 100644
>>> index 000000000000..74e6e2f6f9ed
>>> --- /dev/null
>>> +++ b/include/dt-bindings/iio/qcom,spmi-adc5-gen3-pm8550.h
>>> @@ -0,0 +1,48 @@
>>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> Dual license.
>
>
> I think we do have an internal rule by which we do have to add these two
> licenses....I'll check again and update them if required.
Just to be clear: your internal rules are your internal affair. We
expect here dual license.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-23 6:37 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 7:28 [PATCH 00/11] iio: adc: Add support for QCOM SPMI PMIC5 Gen3 ADC Jishnu Prakash
2023-07-08 7:28 ` [PATCH 01/11] iio: adc: Update bindings for ADC7 name used on QCOM PMICs Jishnu Prakash
2023-07-08 14:58 ` Jonathan Cameron
2023-10-23 6:05 ` Jishnu Prakash
2023-10-23 9:56 ` Jonathan Cameron
2023-07-09 17:17 ` Krzysztof Kozlowski
2023-10-23 6:08 ` Jishnu Prakash
2023-07-08 7:28 ` [PATCH 02/11] iio: adc: Update driver files for ADC7 rename for " Jishnu Prakash
2023-07-08 7:28 ` [PATCH 03/11] ARM: dts: qcom: Update devicetree " Jishnu Prakash
2023-07-09 17:18 ` Krzysztof Kozlowski
2023-10-23 6:09 ` Jishnu Prakash
2023-10-23 6:32 ` Krzysztof Kozlowski
2023-11-09 8:22 ` Jishnu Prakash
2023-11-10 10:59 ` Krzysztof Kozlowski
2023-11-16 3:23 ` Jishnu Prakash
2023-07-08 7:28 ` [PATCH 04/11] iio: adc: Update bindings to remove support for ADC7 name used on " Jishnu Prakash
2023-07-08 15:02 ` Jonathan Cameron
2023-10-23 6:10 ` Jishnu Prakash
2023-07-09 17:19 ` Krzysztof Kozlowski
2023-10-23 6:11 ` Jishnu Prakash
2023-10-23 6:33 ` Krzysztof Kozlowski
2023-07-08 7:28 ` [PATCH 05/11] iio: adc: qcom-spmi-adc5: remove support for ADC7 compatible string Jishnu Prakash
2023-07-08 15:00 ` Jonathan Cameron
2023-10-23 6:11 ` Jishnu Prakash
2023-07-09 17:38 ` Krzysztof Kozlowski
2023-10-23 6:12 ` Jishnu Prakash
2023-07-08 7:28 ` [PATCH 06/11] iio: adc: Add QCOM PMIC5 Gen3 ADC bindings Jishnu Prakash
2023-07-08 15:12 ` Jonathan Cameron
2023-07-08 15:25 ` Jonathan Cameron
2023-10-23 6:13 ` Jishnu Prakash
2023-10-23 6:13 ` Jishnu Prakash
2023-07-09 17:23 ` Krzysztof Kozlowski
2023-10-23 6:14 ` Jishnu Prakash
2023-10-23 6:36 ` Krzysztof Kozlowski [this message]
2023-11-16 3:23 ` Jishnu Prakash
2023-11-16 11:40 ` Krzysztof Kozlowski
2023-11-16 11:46 ` Krzysztof Kozlowski
2023-12-21 8:01 ` Jishnu Prakash
2023-07-08 7:28 ` [PATCH 07/11] iio: adc: Add support for QCOM PMIC5 Gen3 ADC Jishnu Prakash
2023-07-08 15:59 ` Jonathan Cameron
2023-10-23 6:15 ` Jishnu Prakash
2023-10-23 8:03 ` Dmitry Baryshkov
2023-11-16 3:24 ` Jishnu Prakash
2023-07-09 17:41 ` Krzysztof Kozlowski
2023-10-23 6:15 ` Jishnu Prakash
2023-07-08 7:28 ` [PATCH 08/11] dt-bindings: iio: adc: Copy QCOM ADC bindings files Jishnu Prakash
2023-07-09 17:25 ` Krzysztof Kozlowski
2023-10-23 6:16 ` Jishnu Prakash
2023-10-23 6:19 ` Krzysztof Kozlowski
2023-07-08 7:28 ` [PATCH 09/11] iio: adc: Update QCOM ADC drivers for bindings path change Jishnu Prakash
2023-07-08 15:23 ` Jonathan Cameron
2023-10-23 6:17 ` Jishnu Prakash
2023-10-23 7:58 ` Dmitry Baryshkov
2023-11-16 3:24 ` Jishnu Prakash
2023-07-08 7:28 ` [PATCH 10/11] ARM: dts: qcom: Update devicetree for QCOM ADC " Jishnu Prakash
2023-07-09 17:26 ` Krzysztof Kozlowski
2023-10-23 6:18 ` Jishnu Prakash
2023-10-23 6:38 ` Krzysztof Kozlowski
2023-11-10 23:47 ` Bjorn Andersson
2023-11-16 3:25 ` Jishnu Prakash
2023-07-09 17:26 ` Krzysztof Kozlowski
2023-10-23 6:18 ` Jishnu Prakash
2023-07-08 7:28 ` [PATCH 11/11] dt-bindings: iio: remove QCOM ADC files from iio folder Jishnu Prakash
2023-07-09 17:28 ` Krzysztof Kozlowski
2023-10-23 6:19 ` Jishnu Prakash
2023-10-23 6:40 ` Krzysztof Kozlowski
2023-07-08 15:13 ` [PATCH 00/11] iio: adc: Add support for QCOM SPMI PMIC5 Gen3 ADC Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4ef9cac-15ac-4c2c-9f9a-cb9e740e2900@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jic23@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=marijn.suijten@somainline.org \
--cc=quic_collinsd@quicinc.com \
--cc=quic_jprakash@quicinc.com \
--cc=quic_kamalw@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®