From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAEA1C433F5 for ; Mon, 4 Apr 2022 14:07:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358707AbiDDOJV (ORCPT ); Mon, 4 Apr 2022 10:09:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241862AbiDDOJS (ORCPT ); Mon, 4 Apr 2022 10:09:18 -0400 X-Greylist: delayed 1212 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 04 Apr 2022 07:07:22 PDT Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.147.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1E2A3ED2F for ; Mon, 4 Apr 2022 07:07:22 -0700 (PDT) Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 7065119CA3 for ; Mon, 4 Apr 2022 08:47:10 -0500 (CDT) Received: from 162-215-252-75.unifiedlayer.com ([208.91.199.152]) by cmsmtp with SMTP id bN30nlQDQRnrrbN30nofIY; Mon, 04 Apr 2022 08:47:10 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=sBTcpRo+ZmNBLuHykhWfL9kt+ZTCEKXYU6cLW6tiBi4=; b=3WdW7Q9IouJVO/MkGYqsYWrmWQ nnr5k+jVmzZ11583WBJ4vbe64g6OtIk8Gd2Z/ZvmqEGcuER4XId8UdZiXFOaKFqCgqIGDdvsxzDHk eBaqCKoxZgrCjpNcBG9GpIAmOv2Zj2JusoWCR4ti+Dpa53KidF8icLeDjLfwMha6EVnoZVn07ntXx c6hWf32Ox/IuU4lOW4X24Gqzd4cDKstIqT9kEVqg3FYfY5XNdgj2LeU48XzhckEMeEtkZatbmUC5t HpvnCpYhFcnHU91o6tN1t3L492QGn6FgVhfWkSGYpYhV/L6PPCHehYeqf5ZU3tB1si+G+zvcI5vW6 fwbWKyvg==; Received: from 108-223-40-66.lightspeed.sntcca.sbcglobal.net ([108.223.40.66]:54714) by bh-25.webhostbox.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nbN2z-000fkX-NC; Mon, 04 Apr 2022 13:47:09 +0000 Message-ID: Date: Mon, 4 Apr 2022 06:47:08 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] staging: r8188eu: Fix PPPoE tag insertion on big endian systems Content-Language: en-US To: Dan Carpenter Cc: Larry Finger , Phillip Potter , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220401151257.3414576-1-linux@roeck-us.net> <782f0115-e45f-1aff-a152-5d403c990b31@lwfinger.net> <8e68501c-24fd-cfbc-60f2-ec3e277159ab@lwfinger.net> <0c646d80-3198-06c1-e8aa-442b245ffb3e@roeck-us.net> <20220404095312.GV3293@kadam> From: Guenter Roeck In-Reply-To: <20220404095312.GV3293@kadam> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-BWhitelist: no X-Source-IP: 108.223.40.66 X-Source-L: No X-Exim-ID: 1nbN2z-000fkX-NC X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 108-223-40-66.lightspeed.sntcca.sbcglobal.net [108.223.40.66]:54714 X-Source-Auth: linux@roeck-us.net X-Email-Count: 6 X-Source-Cap: cm9lY2s7YWN0aXZzdG07YmgtMjUud2ViaG9zdGJveC5uZXQ= X-Local-Domain: yes Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/4/22 02:53, Dan Carpenter wrote: > On Sat, Apr 02, 2022 at 02:18:22PM -0700, Guenter Roeck wrote: >> On 4/1/22 13:25, Larry Finger wrote: >>> On 4/1/22 14:25, Guenter Roeck wrote: >>>> The rest of the code uses htons/ntohs, so I prefer to follow that lead. >>> >>> You just proved my point. It is hard to get be16_to_cpu() wrong. Sparse will flag the error when you use cpu_to_be16() instead. I expect that your htons/ntohs problem would also have shown up with Sparse. >>> >> >> Ok, you made your point. I'll use be16_to_cpu() - the driver >> already uses it elsewhere anyway. As for the other problems, >> I am not sure if the driver ever worked. The function we are >> looking at can't really have worked on a little endian system >> because of the missing conversion, and the same is true for the >> other code flagged by sparse. I think I'll just add a note >> to this patch and let the driver authors decide what to do >> about those problems. >> >> Guenter > > This is already fixed along with a couple related bugs in commit > 2d959a842a8f ("staging: r8188eu: Fix sparse endianness warnings."). > > https://lore.kernel.org/r/YkPK/QmLAp3BkygY@sckzor-linux.localdomain > > It's in staging-next but hasn't hit linux-next yet. > Good to hear. Too bad I got it a minute too late - I just sent v3. Guenter