Re: [PATCH v2 3/3] i2c: mpc: implement erratum A-004447 workaround

[Joakim Tjernlund <Joakim.Tjernlund@infinera.com>]

On Fri, 2021-05-07 at 14:46 +0300, Andy Shevchenko wrote:
> On Fri, May 7, 2021 at 3:40 AM Chris Packham
> <chris.packham@alliedtelesis.co.nz> wrote:
> > 
> > The P2040/P2041 has an erratum where the normal i2c recovery mechanism
> > does not work. Implement the alternative recovery mechanism documented
> > in the P2040 Chip Errata Rev Q.
> 
> Thanks.
> 
> > +static int i2c_mpc_wait_sr(struct mpc_i2c *i2c, int mask)
> > +{
> > +       int ret;
> > +       u8 val;
> > +
> > +       ret = readb_poll_timeout(i2c->base + MPC_I2C_SR, val,
> > +                                val & mask, 0, 100);
> > +
> > +       return ret;
> > +}
> 
> So, now you may shrink it even further, i.e.
> 
>        void __iomem *sr = i2c->base + MPC_I2C_SR;
>        u8 val;
> 
>        return readb_poll_timeout(sr, val, val & mask, 0, 100);
> 

val looks uninitialised before use?