From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933101AbcIBRMt (ORCPT ); Fri, 2 Sep 2016 13:12:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40542 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932236AbcIBRMr (ORCPT ); Fri, 2 Sep 2016 13:12:47 -0400 Subject: Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit To: Christophe JAILLET , matanb@mellanox.com, leonro@mellanox.com, sean.hefty@intel.com, hal.rosenstock@gmail.com References: <1472188577-14550-1-git-send-email-christophe.jaillet@wanadoo.fr> Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Doug Ledford Message-ID: Date: Fri, 2 Sep 2016 13:12:23 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472188577-14550-1-git-send-email-christophe.jaillet@wanadoo.fr> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FBGBuoqdD0ccTfgv6l0nATw1TsEcHiFdC" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 02 Sep 2016 17:12:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FBGBuoqdD0ccTfgv6l0nATw1TsEcHiFdC Content-Type: multipart/mixed; boundary="pa2B8wc7Of8VnAxLFnVllIbf2MgmC4MmM"; protected-headers="v1" From: Doug Ledford To: Christophe JAILLET , matanb@mellanox.com, leonro@mellanox.com, sean.hefty@intel.com, hal.rosenstock@gmail.com Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Message-ID: Subject: Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit References: <1472188577-14550-1-git-send-email-christophe.jaillet@wanadoo.fr> In-Reply-To: <1472188577-14550-1-git-send-email-christophe.jaillet@wanadoo.fr> --pa2B8wc7Of8VnAxLFnVllIbf2MgmC4MmM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 8/26/2016 1:16 AM, Christophe JAILLET wrote: > The 2nd parameter of 'find_first_bit' is the number of bits to search. > In this case, we are passing 'sizeof(tmp)' which is likely to be 4 or 8= > because 'tmp' is an 'unsigned long'. >=20 > It is likely that the number of bits of 'tmp' was expected here. So use= > BITS_PER_LONG instead. Thanks, applied. --=20 Doug Ledford GPG Key ID: 0E572FDD --pa2B8wc7Of8VnAxLFnVllIbf2MgmC4MmM-- --FBGBuoqdD0ccTfgv6l0nATw1TsEcHiFdC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJXybL3AAoJELgmozMOVy/ddpQQAJWnrHS0lgoRbcaznlLVpYiW E/Xrv5J3DxkjVji4RHaFRoZNoSqf7PPR0PFY4HIdFXNsNnnJukPcoOOWSVMQjGD9 A+EguptQj7DnfifRe43l3E6ATJ5OSFtXTE3p8+j6PD5wRirTiDk7WKbpwQWsW33J Gu9uVlOL3aCLh6hbB/R0tqQFftwu4k443736q7Qk8it9saMV2O3PPvVcNTXvrUkM OPaJhBkWKL6Rgiqn0hcVf2gHKG5pmtxoLy6/W7Wfub4wIcVmvhU2ae4AS24DZUhP Uo7LA2PXrlEwydQRYQGMO7cDSij2tywuWV9QZwdGB8IMErinb6Va6nWLpifooAIT QqPEAHF5JEdBIhBzTfCEDQsc/hbbgmw/zJYjf0iCcrb810Hh8TGNSxIRRXz6woNJ bASlrEfsQ0JXXD66KuGtc1X3H9k4Ejwl88+08jzpc7GwrbvlKcL1AZMKUpRnShDH Yq9Cz7AqKKPdHgSqiOsar5tZ7Z6iLUhteEXQwaKYrffdryoVQR2OlU83er2HM3yc P56UqztrZoLtS388J++8gElBUuKVhEFLclpMYOENVROiUduF0E75KhssPQGWRgIm oAI0MRS5+e+Z/Y1Ww5I4fw6GARXnlmaAai2gKr5jGvxTGU8hFoWSA4etV0W+3GAk sRKD70SV99xh61AGRTzZ =BLvO -----END PGP SIGNATURE----- --FBGBuoqdD0ccTfgv6l0nATw1TsEcHiFdC--