mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>,
	andersson@kernel.org, linusw@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, konradybcio@kernel.org
Cc: srini@kernel.org, linux-arm-msm@vger.kernel.org,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, sibi.sankar@oss.qualcomm.com,
	mohammad.rafi.shaik@oss.qualcomm.com
Subject: Re: [PATCH 2/3] arm64: dts: glymur: Add LPASS macro codecs and pinctrl
Date: Wed, 18 Mar 2026 11:36:23 +0100	[thread overview]
Message-ID: <c50b8a91-ebda-4ba0-984e-b4121a55adf3@oss.qualcomm.com> (raw)
In-Reply-To: <20260311124230.2241781-3-srinivas.kandagatla@oss.qualcomm.com>

On 3/11/26 1:42 PM, Srinivas Kandagatla wrote:
> Add LPASS macro codecs and LPASS TLMM pin controller on Qualcomm glymur.
> for proper sound support.
> 
> Also add GPR(Generic Pack router) node along with
> APM(Audio Process Manager) and PRM(Proxy resource
> Manager) audio services.
> 
> Co-developed-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> ---

[...]

> +		lpass_wsamacro: codec@6c90000 {
> +			compatible = "qcom,glymur-lpass-wsa-macro", "qcom,sm8550-lpass-wsa-macro";
> +			reg = <0 0x06c90000 0 0x1000>;

sz = 0x10_000 (no difference but for completeness)

[...]

> +		lpass_wsa2macro: codec@6cb0000 {
> +			compatible = "qcom,glymur-lpass-wsa-macro", "qcom,sm8550-lpass-wsa-macro";
> +			reg = <0 0x06cb0000 0 0x1000>;

same here

[...]

> +		lpass_tlmm: pinctrl@6e80000 {

unit address doesn't match (reg is correct)

> +			compatible = "qcom,glymur-lpass-lpi-pinctrl", "qcom,sm8650-lpass-lpi-pinctrl";
> +			reg = <0 0x07760000 0 0x20000>;

0 -> 0x0

> +		lpass_vamacro: codec@7660000 {
> +			compatible = "qcom,glymur-lpass-va-macro", "qcom,sm8550-lpass-va-macro";
> +			reg = <0 0x07660000 0 0x1000>;

_at least_ 0x2000, I don't know if the following registers are also
related

Konrad

  reply	other threads:[~2026-03-18 10:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 12:42 [PATCH 0/3] arm64: dts: qcom: add glymur crd audio support Srinivas Kandagatla
2026-03-11 12:42 ` [PATCH 1/3] dt-bindings: pinctrl: qcom,sm8650-lpass-lpi-pinctrl: Add Glymur pinctrl Srinivas Kandagatla
2026-03-13 13:29   ` Krzysztof Kozlowski
2026-03-16  9:11   ` Linus Walleij
2026-03-11 12:42 ` [PATCH 2/3] arm64: dts: glymur: Add LPASS macro codecs and pinctrl Srinivas Kandagatla
2026-03-18 10:36   ` Konrad Dybcio [this message]
2026-03-23 22:13     ` Srinivas Kandagatla
2026-03-11 12:42 ` [PATCH 3/3] arm64: dts: qcom: glymur-crd: add Audio sound card node Srinivas Kandagatla
2026-03-11 13:15   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c50b8a91-ebda-4ba0-984e-b4121a55adf3@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mohammad.rafi.shaik@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sibi.sankar@oss.qualcomm.com \
    --cc=srini@kernel.org \
    --cc=srinivas.kandagatla@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®