From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751663AbdI0Tr5 (ORCPT ); Wed, 27 Sep 2017 15:47:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:53356 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbdI0Trz (ORCPT ); Wed, 27 Sep 2017 15:47:55 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EC862170C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=luto@kernel.org Subject: Re: [PATCH 04/12] platform/x86: dell-smbios: Switch to a WMI-ACPI interface To: Mario Limonciello , dvhart@infradead.org Cc: LKML , platform-driver-x86@vger.kernel.org, quasisec@google.com, pali.rohar@gmail.com References: <4da87eb0d9722ed906615409586a8b4d7becd65c.1505999739.git.mario.limonciello@dell.com> From: Andy Lutomirski Message-ID: Date: Wed, 27 Sep 2017 12:47:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <4da87eb0d9722ed906615409586a8b4d7becd65c.1505999739.git.mario.limonciello@dell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/21/2017 06:57 AM, Mario Limonciello wrote: > The driver currently uses an SMI interface which grants direct access > to physical memory to the platform via a pointer. > > Changing this to operate over WMI-ACPI will use an ACPI OperationRegion > for a buffer of data storage when platform calls are performed. > > This is a safer approach to use in kernel drivers as the platform will > only have access to that OperationRegion. > > As a result, this change removes the dependency on this driver on the > dcdbas kernel module. > > + status = wmi_evaluate_method(DELL_WMI_SMBIOS_GUID, > + 0, 1, &input, &output); It might be nice to add a wmidev_method_evaluate(struct wmi_device *wdev, ...) function to better aligh with the new world order. The only reason I didn't do it is that I didn't convert any drivers that wanted it.