From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32C18360EFF for ; Tue, 30 Jun 2026 08:58:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782809916; cv=none; b=NttBX6Nism/mpotck38l4aMqcmwPqJuP+sFDbUCeazGbwGvjcoJKCBNN5h8my8WUoeYMyXj+vropNlmEAlvhM5p8/Sl6GbnGzw/uHbl/9tlhb6lOybQBuVszaAa+kd4CLEcVsaLyLpmaRn437PMMnisMmFw6REIOQNLWqyHiPXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782809916; c=relaxed/simple; bh=koeVu/f3H9K6MIuQqEas21rxm11JsRsTtYczEVerT5s=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=I/nSTLUvFIGPokuhfWHEw6C8culuaHpNii4udPRFv6yLEkNuU0y6AwzCMmMStCJcH739+VH2mklZqOP1gQzRsuqo+62EZ7+F2xMGth0aBJPiW3V2BD5vDWSY48JdMeMh2C0XE1yUrSJAjIJroLTGejttpesTfbz3DmlHoH9hbYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=T2igFBBF; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=fGS33qxv; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="T2igFBBF"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="fGS33qxv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782809914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=koeVu/f3H9K6MIuQqEas21rxm11JsRsTtYczEVerT5s=; b=T2igFBBFjRQaT1AEOe77kPIsjbOyubSNeUNaw46QiiS44i9o2i87yZOdh+WdnfCa1x6P0j sl8lxN15o09noUMgd5+9Dk+PJJQVP/mPKSgckiAMCjMVnue31vqhT3Qus6bE7WvYudVN3k zgerOmgw4PYWdtNFuivjoLYdV+aMyYc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-206-IlyWflLJNhyWPZp_gQ_14Q-1; Tue, 30 Jun 2026 04:58:31 -0400 X-MC-Unique: IlyWflLJNhyWPZp_gQ_14Q-1 X-Mimecast-MFC-AGG-ID: IlyWflLJNhyWPZp_gQ_14Q_1782809910 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-472a798fc7cso1341786f8f.1 for ; Tue, 30 Jun 2026 01:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782809910; x=1783414710; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=koeVu/f3H9K6MIuQqEas21rxm11JsRsTtYczEVerT5s=; b=fGS33qxvvYTXzGyrNc53ftW0ESgoNVn0Nw9yEkVkp8SFn/dxolabonlL3RVrV6hOzc mq8+BWbNwP0GteXA5uFb6wmGeI0ShiLs+xdpgbCUh6PhS3Jy/yFWp+nwpEeF9/NEn22/ Vn1NPT2Oz/0xjtsdDDdl6c8PuarXmwQYogEDuA8MxI+VFYgRkepWEvijbWm9L/oy6dFy yDbgjQyeXyd8p6V7djeOaeSZHzDvOsyuX2qfmByPI+E3pBUvEh5Qe0NIyg8kFFp8jr1y Fzmw/k1ww4KoN0FoeaKk3wJ4ibRXgXzNKliDLKEFxMeJGu3hyf1CNAecPnXUz389Rqye NhYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782809910; x=1783414710; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=koeVu/f3H9K6MIuQqEas21rxm11JsRsTtYczEVerT5s=; b=qakfytEBD+gLwlvoVZeDFZFZAomORzrQqcuaTncuaCqXDJql7koQeP8KxlAEJsLk1b WMo6Z6rNWybWAIdUWiiOu9S1GUecDm0zXj01tsSlg/FlVH5vnM69chnOg4GzBrDADiYI QqfBLfgkyBI3Og/3oKn2+mr9x9rAa4F5RVyv3JaGaPHTvzWAPEF13cwazHXF1g7dkLod 1wTHZ7/o3HyfEnJ+01jHgCC9yupx2mjfJYDUZCK53kjRmGfgNuzzSCwdSey9WUBoM538 L2YgBrXJNyjGnNWBwNYuPuZ2l7y4eRqh+7w4T9aj1+Z6d2ETOJz3aieWUsQNgEZmQZaa K48w== X-Forwarded-Encrypted: i=1; AHgh+RqBzlivVbiFzsqlvD0gqokSE299ZLXDR5BiYuec1LDjt3k0l4rIdCCwpfSh5CEiHR7SGMx4EZWBgthAcXY=@vger.kernel.org X-Gm-Message-State: AOJu0YzU6Y1iQg6fxA9DoMRuNdGaUT+7ahVhmQ+UIYMNDINo0lIEtN1N zxWXaldBgwt4W/puRcwMePNH6oqMRFcWNegcvtxsOtPj4J3SWk3d/vvjMvTkJ/fLXrTZwDYWi5q W9w0BnlNoUWNr+QEVN0V10D+KnuX1vL0YIga6Gxy+T2eOtSS6r1Ybl3ictF0XSZcNPA== X-Gm-Gg: AfdE7cn08xR8VDlYzoMfJG2VoPG3aLwQvMX+Xu74rgHKTIw6kUF4c84uSXft1omr9Fi dXJz3piuJJebWqeaEjeIsa4o3sVFnfHXKZ60zSWBBKRB1iVtbrbiWHlAB2UoJdnrgJNnVWqQeOE hgmoiZYYxKKdazRjqlyw2bAzInyYfLfJg+OmQ7Y1fuzEIn27j/fy4koi5E8r6WAkvdvnXSwbFPs /ffiCQdV7Z9oITrNuDNixUmN9V6QRhGjwRcFItnzJ8FGW2nbN2ayPoHY6aZYc/HisqRuonuje+3 xtrQVB9kRf0fWH9sVPRKkc7NPqE4RP+6PYKh9XyOlF2BJUELM5vP37N858KeVc03xp4Ovzkc7gb g7SeDmkxUb70HlsOxyFTui5meClRlZanT/tPm3RkUUQRAXqpsep2ccmmrqpSx58h6bxlTjIv1lL IbLzig X-Received: by 2002:a05:6000:2408:b0:475:f0f0:9ec7 with SMTP id ffacd0b85a97d-475f0f0a01bmr1236214f8f.50.1782809909864; Tue, 30 Jun 2026 01:58:29 -0700 (PDT) X-Received: by 2002:a05:6000:2408:b0:475:f0f0:9ec7 with SMTP id ffacd0b85a97d-475f0f0a01bmr1236179f8f.50.1782809909447; Tue, 30 Jun 2026 01:58:29 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-475641e4659sm6144598f8f.12.2026.06.30.01.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 01:58:29 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2] sched: set TIF_NEED_RESCHED before calling __trace_set_need_resched() From: Gabriele Monaco To: K Prateek Nayak , Sechang Lim , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Cc: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , linux-kernel@vger.kernel.org Date: Tue, 30 Jun 2026 10:58:27 +0200 In-Reply-To: <5f47566b-88f4-458d-87a4-7794e6ba8203@amd.com> References: <20260627081657.499781-1-rhkrqnwk98@gmail.com> <6cbcc3ea742b92b6a34b5994f5498c7611beac7e.camel@redhat.com> <5f47566b-88f4-458d-87a4-7794e6ba8203@amd.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-06-29 at 23:05 +0530, K Prateek Nayak wrote: > > That said, we should indeed add the tracepoint to that path and probabl= y > > adapt the monitor if that's making it fail indirectly. >=20 > For the npr use-case, I think the current scheme is fine since > only SM_PREEMPt counts as a "schedule_entry_preempt" transition > and only that can transition the state machine out of the > "any_thread_running" state. Right, the monitor can live without it, but I wonder if we need to put that tracepoint for correctness sake. After all, however unlikely, that's a need_resched too. (then if the monitor really saw a need_resched after it's sched_entry, it w= ould stay erroneously in rescheduling). Anyway this all isn't related to the patch. Thanks, Gabriele