mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Matthias Brugger <matthias.bgg@gmail.com>, linux-kernel@vger.kernel.org
Cc: Collabora Kernel ML <kernel@collabora.com>,
	erwanaliasr1@gmail.com, drinkcat@chromium.org,
	hsinyi@chromium.org, Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 4/7] arm64: dts: mt8183: Fix unit name warnings
Date: Thu, 25 Jun 2020 10:39:13 +0200	[thread overview]
Message-ID: <c519de37-1377-9860-d831-0781c259cc0c@collabora.com> (raw)
In-Reply-To: <ec4fb6c1-37a3-08b2-ae57-3e35868383ef@gmail.com>

Hi Matthias,

Thank you for you review.

On 22/6/20 12:14, Matthias Brugger wrote:
> 
> 
> On 19/06/2020 12:27, Enric Balletbo i Serra wrote:
>> Remove the unit address from the DT nodes that doesn't have a reg
>> property. This fixes the following unit name warnings:
>>
>>   Warning (unit_address_vs_reg): /cpus/idle-states/cluster-sleep@0: node has a unit name, but no reg or ranges property
>>   Warning (unit_address_vs_reg): /cpus/idle-states/cluster-sleep@1: node has a unit name, but no reg or ranges property
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> ---
>>
>>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index 00137ec61164d..e356076749148 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -168,7 +168,7 @@ CPU_SLEEP: cpu-sleep {
>>  				min-residency-us = <800>;
>>  			};
>>  
>> -			CLUSTER_SLEEP0: cluster-sleep@0 {
>> +			CLUSTER_SLEEP0: cluster-sleep0 {
> 
> Should be:
> cluster-sleep-0
> 

Ack, I'll change in next version

>>  				compatible = "arm,idle-state";
>>  				local-timer-stop;
>>  				arm,psci-suspend-param = <0x01010001>;
>> @@ -176,7 +176,7 @@ CLUSTER_SLEEP0: cluster-sleep@0 {
>>  				exit-latency-us = <400>;
>>  				min-residency-us = <1000>;
>>  			};
>> -			CLUSTER_SLEEP1: cluster-sleep@1 {
>> +			CLUSTER_SLEEP1: cluster-sleep1 {
> 
> Same here.
> 

Ack.

> Regards,
> Matthias1
> 
>>  				compatible = "arm,idle-state";
>>  				local-timer-stop;
>>  				arm,psci-suspend-param = <0x01010001>;
>>

  reply	other threads:[~2020-06-25  8:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 10:27 [PATCH 0/7] arm64: dts: mediatek: Add support for Lenovo IdeaPad Duet Chromebook Enric Balletbo i Serra
2020-06-19 10:27 ` [PATCH 1/7] dt-bindings: arm64: dts: mediatek: Add mt8183-kukui-krane-sku176 Enric Balletbo i Serra
2020-06-19 10:27 ` [PATCH 2/7] arm64: dts: mt6358: Add the compatible for the regulators Enric Balletbo i Serra
2020-06-19 10:27 ` [PATCH 3/7] arm64: dts: mt8183: Add MediaTek's peripheral configuration controller Enric Balletbo i Serra
2020-06-19 10:27 ` [PATCH 4/7] arm64: dts: mt8183: Fix unit name warnings Enric Balletbo i Serra
2020-06-22 10:14   ` Matthias Brugger
2020-06-25  8:39     ` Enric Balletbo i Serra [this message]
2020-06-19 10:27 ` [PATCH 5/7] arm64: dts: mt8183-evb: " Enric Balletbo i Serra
2020-06-19 10:27 ` [PATCH 6/7] arm64: dts: mt8183: Add USB3.0 support Enric Balletbo i Serra
2020-06-19 10:27 ` [PATCH 7/7] arm64: dts: mt8183: Add krane-sku176 board Enric Balletbo i Serra
2020-06-22 10:33   ` Matthias Brugger
2020-06-25  8:40     ` Enric Balletbo i Serra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c519de37-1377-9860-d831-0781c259cc0c@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=erwanaliasr1@gmail.com \
    --cc=hsinyi@chromium.org \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®