Re: [PATCH 4/4] nfc: llcp_sock_sendmsg: Reformat code to make the smaller block indented

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 25/11/2023 21:26, Siddh Raman Pant wrote:
> The block for datagram sending is a significantly bigger chunk of the
> function compared to the other scenario.
> 
> Thus, put the significantly smaller block inside the if-block.
> 


>  
> +	if (sk->sk_state != LLCP_BOUND) {
>  		release_sock(sk);
> -
> -		return nfc_llcp_send_ui_frame(llcp_sock, addr->dsap, addr->ssap,
> -					      msg, len);
> +		return -ENOTCONN;
>  	}
>  
> -	if (sk->sk_state != LLCP_CONNECTED) {
> +	DECLARE_SOCKADDR(struct sockaddr_nfc_llcp *, addr, msg->msg_name);

No, this code is not readable. I don't think this change helps in anything.

> +
> +	if (msg->msg_namelen < sizeof(*addr)) {
>  		release_sock(sk);
> -		return -ENOTCONN;
> +		return -EINVAL;
>  	}
>  
>  	release_sock(sk);
>  
> -	return nfc_llcp_send_i_frame(llcp_sock, msg, len);
> +	return nfc_llcp_send_ui_frame(llcp_sock, addr->dsap, addr->ssap,
> +				      msg, len);
> +

Stray blank line.


Best regards,
Krzysztof