From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD40C4332F for ; Tue, 12 Dec 2023 11:05:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229456AbjLLLFn (ORCPT ); Tue, 12 Dec 2023 06:05:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230497AbjLLLFk (ORCPT ); Tue, 12 Dec 2023 06:05:40 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 988F6AB; Tue, 12 Dec 2023 03:05:45 -0800 (PST) Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SqG4J43J8zsSFp; Tue, 12 Dec 2023 19:05:36 +0800 (CST) Received: from kwepemm000007.china.huawei.com (unknown [7.193.23.189]) by mail.maildlp.com (Postfix) with ESMTPS id 24A7B180032; Tue, 12 Dec 2023 19:05:43 +0800 (CST) Received: from [10.67.120.192] (10.67.120.192) by kwepemm000007.china.huawei.com (7.193.23.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 12 Dec 2023 19:05:42 +0800 Message-ID: Date: Tue, 12 Dec 2023 19:05:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: , , , , , , , , , , Subject: Re: [PATCH net-next 1/6] net: hns3: add support for page_pool_get_stats To: Jakub Kicinski References: <20231211020816.69434-1-shaojijie@huawei.com> <20231211020816.69434-2-shaojijie@huawei.com> <20231211191759.61764363@kernel.org> From: Jijie Shao In-Reply-To: <20231211191759.61764363@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.120.192] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm000007.china.huawei.com (7.193.23.189) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org on 2023/12/12 11:17, Jakub Kicinski wrote: > On Mon, 11 Dec 2023 10:08:11 +0800 Jijie Shao wrote: >> Add support for page_pool_get_stats, then the hns3 driver >> can get page pool statistics by ethtool. > Sorry, you're late to the party :( We have now added the ability to > read page pool stats via netlink. The support was merged as > a379972973a80924b1d03443e20f113ff76a94c7. > > If you use the page pools in your driver in a normal way (each page > pool only used by one NAPI instance and one netdev) you should use > that instead of dumping the stats into ethtool -S. Okay, we'll try to use netlink instead of ethtool. And this patch will be dropped in v2 patch set. Jijie