From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5818DCA1001 for ; Tue, 5 Sep 2023 20:07:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242513AbjIEUH0 (ORCPT ); Tue, 5 Sep 2023 16:07:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233069AbjIEUHZ (ORCPT ); Tue, 5 Sep 2023 16:07:25 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92C73AB for ; Tue, 5 Sep 2023 13:07:22 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3ff1c397405so29418205e9.3 for ; Tue, 05 Sep 2023 13:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; t=1693944441; x=1694549241; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=spuMELZAIK25d9LF4p1nwmtF1Z+Tv/kzkeUVaMdUjGk=; b=Cke1oE+NHumFTd/QMXVEw+nwznxEltZXbEcGcYoVZqAgI53tii3YSoRX/PGd80G2XO xuiWv8pJL/kKt8ESlvfB3dB+Q2pINDBcpPWbI29q1Ncly4L/llczZLcdpVC7zXlwLjQi 1vhBRU/G875Xj8hnOmb72qyARwDNwP3/vJMWWmUZSwBSBiXe1FYoHQED0w3sCQpvr1Oy kppKPSzDD/vy0tf0ZhTt4rjNMvRSstmKRmKuGHB+tjfiM6kMzmm1xpwIF3zDGolF0Tyt l5AWR6TEFXOPrBwUBxEtD/Iny+UTdXCzBeVV26AYUKk8KyZx4uQbRM9aXHz5NbpAfLMx +E+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693944441; x=1694549241; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=spuMELZAIK25d9LF4p1nwmtF1Z+Tv/kzkeUVaMdUjGk=; b=X/N/PtGkRiXA9K//kgfqImAfJs6vqdqYZjZ4w72SFJY6dnGhKudy3o473B+WPSNw/U tje47yVu34A5wHrDjFODaoevWu+fP2ETO80mqi7UxQFrHj00fzacs8fUHJOlAJn2aJcv 17un8380ijgHt27v34vZGl0/i3ed+h3v7C3RskzKTI86Ko2T0ph/B2ECZfeyqkgDqIbE OPVjeOfkGFZiGRGOoJ1P6tXdrVsLyvN3/lSFkNJU6cWKZkbU7SXmzbS4wlm+zZAqBNPp yHm/aV0WXTqZShjj65WuUBnX7eVrQvRDE0gG8xx4YPjkHRXIDBSXeGuc7zsxX0puO+Ty xs9g== X-Gm-Message-State: AOJu0Yxvzq1MphXcdszMWfShUpx1L9lM16iRx8oHTH6VcJwo3Z7voj+a qr8gQX4EuzZ1CEkLBq1V4PfIuw== X-Google-Smtp-Source: AGHT+IFuAK9xqudXSSiNQNp2+PdZSC2Sh6T0PSGyQ357ScwCvVeLtVGFD8Hgd4zd2DNLWPQAMUwOYw== X-Received: by 2002:a05:600c:2409:b0:3fa:97ad:2ba5 with SMTP id 9-20020a05600c240900b003fa97ad2ba5mr626043wmp.31.1693944440998; Tue, 05 Sep 2023 13:07:20 -0700 (PDT) Received: from [10.83.37.178] ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id d15-20020adffd8f000000b00317ab75748bsm18411054wrr.49.2023.09.05.13.07.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 13:07:20 -0700 (PDT) Message-ID: Date: Tue, 5 Sep 2023 21:07:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v10 net-next 09/23] net/tcp: Add TCP-AO sign to twsk Content-Language: en-US To: Simon Horman Cc: David Ahern , Eric Dumazet , Paolo Abeni , Jakub Kicinski , "David S. Miller" , linux-kernel@vger.kernel.org, Andy Lutomirski , Ard Biesheuvel , Bob Gilligan , Dan Carpenter , David Laight , Dmitry Safonov <0x7f454c46@gmail.com>, Donald Cassidy , Eric Biggers , "Eric W. Biederman" , Francesco Ruggeri , "Gaillardetz, Dominik" , Herbert Xu , Hideaki YOSHIFUJI , Ivan Delalande , Leonard Crestez , "Nassiri, Mohammad" , Salam Noureddine , Simon Horman , "Tetreault, Francois" , netdev@vger.kernel.org References: <20230815191455.1872316-1-dima@arista.com> <20230815191455.1872316-10-dima@arista.com> From: Dmitry Safonov In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/16/23 13:03, Simon Horman wrote: > On Tue, Aug 15, 2023 at 08:14:38PM +0100, Dmitry Safonov wrote: > > ... > >> @@ -1183,6 +1216,7 @@ static void tcp_v6_reqsk_send_ack(const struct sock *sk, struct sk_buff *skb, >> ipv6_get_dsfield(ipv6_hdr(skb)), 0, >> READ_ONCE(sk->sk_priority), >> READ_ONCE(tcp_rsk(req)->txhash)); >> + NULL, NULL, 0, 0); > > Hi Dmitry, > > This seems to add a syntax error. > > ... Rectified by "net/tcp: Wire TCP-AO to request sockets". Likely, an artifact from the rebase over READ_ONCE() for txhash. I will correct it in v11, thanks for noticing! -- Dmitry