From: Markus Elfring <Markus.Elfring@web.de>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: soc-ac97: Fix the incorrect description
Date: Sun, 8 Sep 2024 17:15:12 +0200 [thread overview]
Message-ID: <c5264db6-857e-4047-82ed-549f06f38681@web.de> (raw)
In-Reply-To: <20240908124124.1971-1-tangbin@cmss.chinamobile.com>
> In the function snd_soc_alloc_ac97_component &
> snd_soc_new_ac97_component, the error return is
> ERR_PTR, so fix the incorrect description.
1. You may occasionally put more than 47 characters into text lines
of such a change description.
2. How do you think about to use the term “error pointer” here
(instead of the mentioned inline function name)?
https://elixir.bootlin.com/linux/v6.11-rc6/source/include/linux/err.h#L31
Regards,
Markus
next prev parent reply other threads:[~2024-09-08 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 12:41 Tang Bin
2024-09-08 15:15 ` Markus Elfring [this message]
2024-09-09 17:26 ` Mark Brown
2024-09-10 17:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5264db6-857e-4047-82ed-549f06f38681@web.de \
--to=markus.elfring@web.de \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tangbin@cmss.chinamobile.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®